Update clang-format to something more modern

[jleidel]

Update clang-format to something more modern

[jleidel]

clang-format 13 is verified to be broken against the current source tree. this implies either hammering the clang-format version in the checker script to 12 and only 12.. or... fixing the clang-format descriptors to support multiple versions

[kpgriesser]

I'd suggest a pre-commit hook to enable the developer to deal with the issues before submitting PR

[gvoskuilen]

At minimum, use the clang-format wrapper script - sst-core/scripts/clang-format-test.sh which does enforce the version. It passes arguments through to clang-format.

[jleidel]

At minimum, use the clang-format wrapper script - sst-core/scripts/clang-format-test.sh which does enforce the version. It passes arguments through to clang-format.

It allows version 12 and 13

[jleidel]

./scripts/clang-format-test.sh --format-exe clang-format-13
Using clang-format clang-format-13 with arguments --dry-run.
./scripts/clang-format-test.sh: line 41: [: -lt: unary operator expected
./scripts/clang-format-test.sh: line 46: [: -ge: unary operator expected
=======================================
=== PERFORMING CLANG-FORMAT TESTING ===
=======================================

=== CLANG-FORMAT FINISHED *.h CHECKS WITH RTN CODE 0

=== CLANG-FORMAT FINISHED *.cc CHECKS WITH RTN CODE 0

=== CLANG FORMAT RESULT FILE FOR .h FILES IS EMPTY - SUCCESS

=== CLANG FORMAT RESULT FILE FOR .cc FILES IS EMPTY - SUCCESS

========================================
=== FINAL TEST RESULT = (0) - PASSED ===
========================================

[gvoskuilen]

I

At minimum, use the clang-format wrapper script - sst-core/scripts/clang-format-test.sh which does enforce the version. It passes arguments through to clang-format.

It allows version 12 and 13

The script is not finding the version then, given the unary error message. What does $ clang-format --version give you? I can fix the script issue to handle empty string but it ideally wouldn't get that in the first place.

[berquist]

I'd suggest a pre-commit hook to enable the developer to deal with the issues before submitting PR

It exists and works, but CI is still reliant on the separate shell script until #1239 is done.

[jleidel]

I

At minimum, use the clang-format wrapper script - sst-core/scripts/clang-format-test.sh which does enforce the version. It passes arguments through to clang-format.

It allows version 12 and 13

The script is not finding the version then, given the unary error message. What does $ clang-format --version give you? I can fix the script issue to handle empty string but it ideally wouldn't get that in the first place.

clang-format-13 --version
Ubuntu clang-format version 13.0.1-2ubuntu2.2

[gvoskuilen]

I

At minimum, use the clang-format wrapper script - sst-core/scripts/clang-format-test.sh which does enforce the version. It passes arguments through to clang-format.

It allows version 12 and 13

The script is not finding the version then, given the unary error message. What does $ clang-format --version give you? I can fix the script issue to handle empty string but it ideally wouldn't get that in the first place.

clang-format-13 --version
Ubuntu clang-format version 13.0.1-2ubuntu2.2

I think the issue is that the script is looking for the version number in the 3rd word returned by clang-format --version but your clang-format returns it in the fourth. Thanks! I'll fix it.