fix: ensure collections are initialized before manipulation in Anomaly and IonStorm classes

Author: g5bot

src/Component/Anomaly/Type/IonStorm/IonStormPropagation.php

@@ -21,12 +21,13 @@ public function __construct(
 
     public function propagateStorm(Anomaly $root, LocationPool $locationPool): void
     {
-        if ($root->getChildren()->isEmpty()) {
+        $children = $root->getChildren()->toArray();
+        if ($children === []) {
             $root->setRemainingTicks(0);
             return;
         }
 
-        foreach ($root->getChildren()->toArray() as $child) {
+        foreach ($children as $child) {
             $this->transferRemainingTicks(
                 $root,
                 $child,

src/Component/Anomaly/Type/IonStorm/LocationPoolFactory.php

@@ -26,7 +26,8 @@ public function createLocationPool(Anomaly $anomaly, int $stretch): LocationPool
     private function getLocations(Anomaly $anomaly, int $stretch): array
     {
         $panelBoundaries = null;
-        foreach ($anomaly->getChildren() as $child) {
+        $children = $anomaly->getChildren()->toArray();
+        foreach ($children as $child) {
 
             $location = $child->getLocation();
             if ($location === null) {

src/Orm/Entity/Anomaly.php

@@ -117,10 +117,12 @@ public function setLocation(?Location $location): Anomaly
         $key = $this->anomalyType->getId();
 
         if ($old !== null) {
+            $old->getAnomalies()->toArray(); // make sure the collection is initialized
             $old->getAnomalies()->remove($key);
         }
 
         if ($location !== null && !$location->getAnomalies()->containsKey($key)) {
+            $location->getAnomalies()->toArray(); // make sure the collection is initialized
             $location->getAnomalies()->set($key, $this);
         }
 
@@ -132,13 +134,14 @@ public function getParent(): ?Anomaly
         return $this->parent;
     }
 
-    public function setParent(Anomaly $parent, Location $location): Anomaly
+    public function setParent(Anomaly $parent, Location $location): Anomaly //check
     {
         if ($this->parent === $parent) {
             return $this;
         }
 
         $this->parent = $parent;
+        $parent->getChildren()->toArray(); // make sure the collection is initialized
         $parent->getChildren()->set($location->getId(), $this);
 
         return $this;
@@ -170,7 +173,7 @@ public function getChildren(): Collection
 
     public function hasChildren(): bool
     {
-        return !$this->getChildren()->isEmpty();
+        return $this->getChildren()->toArray() !== [];
     }
 
     #[\Override]

src/Orm/Repository/AnomalyRepository.php

@@ -36,11 +36,13 @@ public function delete(Anomaly $anomaly): void
     {
         $location = $anomaly->getLocation();
         if ($location !== null) {
+            $location->getAnomalies()->toArray(); // make sure the collection is initialized
             $location->getAnomalies()->removeElement($anomaly);
         }
 
         $parent = $anomaly->getParent();
         if ($parent !== null) {
+            $parent->getChildren()->toArray(); // make sure the collection is initialized
             $parent->getChildren()->removeElement($anomaly);
         }
 

tests/unit/Component/Anomaly/Type/IonStorm/IonStormPropagationTest.php

@@ -97,7 +97,6 @@ public function testPropagateStorm(): void
 
         $root->shouldReceive('getChildren')
             ->withNoArgs()
-            ->twice()
             ->andReturn(new ArrayCollection([
                 $child1,
                 $child2WithIonStormOnNeighbour,

tests/unit/Orm/Entity/AnomalyTest.php

@@ -38,18 +38,16 @@ public function testSetLocation(): void
 
     public function testSetParent(): void
     {
-        $parent = $this->createMock(Anomaly::class);
-        $location = $this->createMock(Location::class);
+        $parent = $this->mock(Anomaly::class);
+        $location = $this->mock(Location::class);
 
         $anomaly = new Anomaly();
 
-        $parent->expects($this->once())
-            ->method('getChildren')
-            ->willReturn(new \Doctrine\Common\Collections\ArrayCollection());
+        $parent->shouldReceive('getChildren')
+            ->andReturn(new \Doctrine\Common\Collections\ArrayCollection());
 
-        $location->expects($this->once())
-            ->method('getId')
-            ->willReturn(42);
+        $location->shouldReceive('getId')
+            ->andReturn(42);
 
         $anomaly->setParent($parent, $location);