fix ticket 1011

Author: Huxinator

src/Module/Communication/Action/AddKnPost/AddKnPost.php

@@ -85,6 +85,7 @@ public function handle(GameControllerInterface $game): void
         $characterIdsInput = $this->addKnPostRequest->getCharacterIds();
         $idsRaw = explode(',', $characterIdsInput);
         $validIds = [];
+        $addedCharacterIds = [];
 
         foreach ($idsRaw as $idRaw) {
             $idTrimmed = trim($idRaw);
@@ -99,14 +100,18 @@ public function handle(GameControllerInterface $game): void
                 $game->getInfo()->addInformation(_("Kein Character mit der ID $id gefunden."));
                 continue;
             }
+            if ($userCharacter->getUser()->getId() === UserConstants::USER_NOONE) {
+                continue;
+            }
 
             $character = $this->knCharactersRepository->prototype();
             $character->setUserCharacter($userCharacter);
             $character->setKnPost($post);
             $this->knCharactersRepository->save($character);
             $post->getKnCharacters()->add($character);
+            $addedCharacterIds[] = $id;
         }
-        $this->notifyCharacterOwners($post, $validIds);
+        $this->notifyCharacterOwners($post, $addedCharacterIds);
 
         if ($plot !== null) {
             $this->newKnPostNotificator->notify($post, $plot);
@@ -134,6 +139,9 @@ private function notifyCharacterOwners(KnPost $post, array $characterIds): void
             $character = $this->userCharactersRepository->find($characterId);
             if ($character !== null) {
                 $ownerId = $character->getUser()->getId();
+                if ($ownerId === UserConstants::USER_NOONE) {
+                    continue;
+                }
 
                 $characterNameWithId = sprintf('%s (%d)', $character->getName(), $characterId);
                 if (!array_key_exists($ownerId, $userCharactersMap)) {

src/Module/Communication/Action/EditKnPost/EditKnPost.php

@@ -86,15 +86,23 @@ public function handle(GameControllerInterface $game): void
 
         foreach ($charactersToAdd as $characterId) {
             $character = $this->userCharactersRepository->find($characterId);
-            if ($character !== null && $character->getUser()->getId() !== $userId) {
+            if (
+                $character !== null
+                && $character->getUser()->getId() !== $userId
+                && $character->getUser()->getId() !== UserConstants::USER_NOONE
+            ) {
                 $ownerId = $character->getUser()->getId();
                 $charactersAddedMapping[$ownerId][] = sprintf('%s (%d)', $character->getName(), $characterId);
             }
         }
 
         foreach ($charactersToRemove as $characterId) {
             $character = $this->userCharactersRepository->find($characterId);
-            if ($character !== null && $character->getUser()->getId() !== $userId) {
+            if (
+                $character !== null
+                && $character->getUser()->getId() !== $userId
+                && $character->getUser()->getId() !== UserConstants::USER_NOONE
+            ) {
                 $ownerId = $character->getUser()->getId();
                 $charactersRemovedMapping[$ownerId][] = sprintf('%s (%d)', $character->getName(), $characterId);
             }
@@ -152,7 +160,10 @@ public function handle(GameControllerInterface $game): void
         foreach ($newCharacterIds as $newCharacterId) {
             if (!in_array($newCharacterId, $currentCharacterIds)) {
                 $userCharacter = $this->userCharactersRepository->find($newCharacterId);
-                if ($userCharacter) {
+                if (
+                    $userCharacter !== null
+                    && $userCharacter->getUser()->getId() !== UserConstants::USER_NOONE
+                ) {
                     $newEntity = $this->knCharactersRepository->prototype();
                     $newEntity->setUserCharacter($userCharacter);
                     $newEntity->setKnPost($post);

tests/unit/Module/Alliance/View/Diplomatic/DiplomaticRelationsTest.php

@@ -70,7 +70,7 @@ public function testHandleRenders(): void
             )
             ->once();
 
-        $this->allianceRelationRepository->shouldReceive('findAll')
+        $this->allianceRelationRepository->shouldReceive('getActive')
             ->withNoArgs()
             ->once()
             ->andReturn([$relation]);