fix ticket-0679

Author: g5bot

src/Lib/Pirate/PirateReaction.php

@@ -11,6 +11,7 @@
 use Stu\Module\Logging\PirateLoggerInterface;
 use Stu\Module\PlayerSetting\Lib\UserEnum;
 use Stu\Module\Ship\Lib\FleetWrapperInterface;
+use Stu\Module\Ship\Lib\ShipWrapperInterface;
 use Stu\Module\Spacecraft\Lib\SpacecraftWrapperFactoryInterface;
 use Stu\Orm\Entity\FleetInterface;
 use Stu\Orm\Entity\ShipInterface;
@@ -119,13 +120,7 @@ public function react(
 
     private function canAnyoneFire(FleetWrapperInterface $fleetWrapper): bool
     {
-        foreach ($fleetWrapper->getShipWrappers() as $wrapper) {
-            if ($wrapper->canFire()) {
-                return true;
-            }
-        }
-
-        return false;
+        return $fleetWrapper->getShipWrappers()->exists(fn(int $key, ShipWrapperInterface $wrapper): bool => $wrapper->canFire());
     }
 
     private function getRandomBehaviourType(PirateReactionTriggerEnum $reactionTrigger): PirateBehaviourEnum

src/Module/Spacecraft/Lib/Movement/ShipMover.php

@@ -157,11 +157,13 @@ private function travelFlightRoute(
             $hasTravelled = true;
 
             // alert reaction check
-            $this->alertReactionCheck(
-                $leadWrapper,
-                $movedTractoredShipWrappers,
-                $messages
-            );
+            if (!$this->areAllShipsDestroyed($activeWrappers)) {
+                $this->alertReactionCheck(
+                    $leadWrapper,
+                    $movedTractoredShipWrappers,
+                    $messages
+                );
+            }
 
             if ($this->areAllShipsDestroyed($activeWrappers)) {
                 $flightRoute->abortFlight();

tests/unit/Module/Spacecraft/Lib/Movement/ShipMoverTest.php

@@ -304,4 +304,127 @@ public function testCheckAndMoveExpectLossOfEmptyShipIfNotFixed(): void
 
         $this->subject->checkAndMove($wrapper, $flightRoute);
     }
+
+    public function testCheckAndMoveExpectNoAlertCheckIfDestroyedOnEntrance(): void
+    {
+        $ship = $this->mock(ShipInterface::class);
+        $wrapper = $this->mock(ShipWrapperInterface::class);
+        $flightRoute = $this->mock(FlightRouteInterface::class);
+        $map = $this->mock(MapInterface::class);
+        $conditionCheckResult = $this->mock(ConditionCheckResult::class);
+        $messageCollection = $this->mock(MessageCollectionInterface::class);
+        $emptyMessage = $this->mock(MessageInterface::class);
+
+        $shipId = 12345;
+
+        $ship->shouldReceive('getId')
+            ->withNoArgs()
+            ->once()
+            ->andReturn($shipId);
+        $ship->shouldReceive('getName')
+            ->withNoArgs()
+            ->once()
+            ->andReturn("SHIP");
+        $ship->shouldReceive('isFleetLeader')
+            ->withNoArgs()
+            ->once()
+            ->andReturn(false);
+        $ship->shouldReceive('getTractoredShip')
+            ->withNoArgs()
+            ->andReturn(null);
+        $ship->shouldReceive('isDestroyed')
+            ->withNoArgs()
+            ->times(5)
+            ->andReturn(false, true, true, true, true);
+        $ship->shouldReceive('getLocation')
+            ->withNoArgs()
+            ->once()
+            ->andReturn($map);
+
+        $map->shouldReceive('getAnomalies')
+            ->withNoArgs()
+            ->once()
+            ->andReturn(new ArrayCollection());
+        $map->shouldReceive('getBuoys')
+            ->withNoArgs()
+            ->once()
+            ->andReturn(new ArrayCollection());
+
+        $wrapper->shouldReceive('get')
+            ->withNoArgs()
+            ->andReturn($ship);
+        $wrapper->shouldReceive('getFleetWrapper')
+            ->withNoArgs()
+            ->andReturn(null);
+        $wrapper->shouldReceive('getTractoredShipWrapper')
+            ->withNoArgs()
+            ->once()
+            ->andReturn(null);
+
+        $map->shouldReceive('getFieldType->getPassable')
+            ->withNoArgs()
+            ->once()
+            ->andReturn(true);
+
+        $flightRoute->shouldReceive('isDestinationArrived')
+            ->withNoArgs()
+            ->times(2)
+            ->andReturn(false, true);
+        $flightRoute->shouldReceive('getNextWaypoint')
+            ->withNoArgs()
+            ->once()
+            ->andReturn($map);
+        $flightRoute->shouldReceive('enterNextWaypoint')
+            ->with(
+                Mockery::on(fn(ArrayCollection $coll) => $coll->toArray() === [$shipId => $wrapper]),
+                $messageCollection
+            )
+            ->once();
+        $flightRoute->shouldReceive('getRouteMode')
+            ->withNoArgs()
+            ->once()
+            ->andReturn(RouteModeEnum::FLIGHT);
+        $flightRoute->shouldReceive('abortFlight')
+            ->withNoArgs()
+            ->once();
+
+        $conditionCheckResult->shouldReceive('isFlightPossible')
+            ->withNoArgs()
+            ->once()
+            ->andReturn(true);
+        $conditionCheckResult->shouldReceive('getBlockedIds')
+            ->withNoArgs()
+            ->once()
+            ->andReturn([]);
+        $conditionCheckResult->shouldReceive('getInformations')
+            ->withNoArgs()
+            ->once()
+            ->andReturn([]);
+
+        $this->preFlightConditionsCheck->shouldReceive('checkPreconditions')
+            ->with($wrapper, [$shipId => $wrapper], $flightRoute, false)
+            ->once()
+            ->andReturn($conditionCheckResult);
+
+        $this->messageFactory->shouldReceive('createMessageCollection')
+            ->withNoArgs()
+            ->once()
+            ->andReturn($messageCollection);
+        $messageCollection->shouldReceive('add')
+            ->with($emptyMessage)
+            ->once();
+        $messageCollection->shouldReceive('addInformation')
+            ->with('Es wurden alle Schiffe zerstört')
+            ->once();
+        $this->messageFactory->shouldReceive('createMessage')
+            ->with(UserEnum::USER_NOONE, null, [])
+            ->once()
+            ->andReturn($emptyMessage);
+
+        $this->shipMovementInformationAdder->shouldReceive('reachedDestinationDestroyed')
+            ->with($ship, 'SHIP', false, RouteModeEnum::FLIGHT, $messageCollection)
+            ->once();
+
+        $this->subject->checkAndMove($wrapper, $flightRoute);
+    }
 }