detect syntax errors in PDO->prepare() (#35)

Co-authored-by: Markus Staab <[email protected]>

Author: staabm

README.md

@@ -5,6 +5,7 @@ This extension provides following features:
 * `PDO->query` knows the array shape of the returned results and therefore can return a generic `PDOStatement`
 * `mysqli->query` knows the array shape of the returned results and therefore can return a generic `mysqli_result`
 * `SyntaxErrorInQueryMethodRule` can inspect sql queries and detect syntax errors - `SyntaxErrorInQueryFunctionRule` can do the same for functions
+  * builtin is query syntax error detection for `mysqli_query`, `mysqli->query`, `PDO->query` and `PDO->prepare`
 * `mysqli_real_escape_string` and `mysqli->real_escape_string` dynamic return type extensions
 * `pdo->quote` dynamic return type extension
 

config/dba.neon

@@ -9,6 +9,7 @@ services:
 		arguments:
 			classMethods:
 				- 'PDO::query#0'
+				- 'PDO::prepare#0'
 				- 'mysqli::query#0'
 
 	-

tests/SyntaxErrorInQueryMethodRuleTest.php

@@ -49,6 +49,10 @@ public function testSyntaxErrorInQueryRule(): void
                 "Query error: Table 'phpstan_dba.unknownTable' doesn't exist (1146).",
                 41,
             ],
+            [
+                "Query error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'freigabe1u1 FROM ada LIMIT 0' at line 1 (1064).",
+                75,
+            ],
         ]);
     }
 }

tests/data/syntax-error-in-query.php

@@ -6,7 +6,7 @@
 
 class Foo
 {
-    public function syntaxErrorPdo(PDO $pdo)
+    public function syntaxErrorPdoQuery(PDO $pdo)
     {
         $pdo->query('SELECT email adaid WHERE gesperrt freigabe1u1 FROM ada', PDO::FETCH_ASSOC);
     }
@@ -69,4 +69,9 @@ public function queryWithPlaceholder(PDO $pdo)
         $pdo->query('SELECT email, adaid, gesperrt, freigabe1u1 FROM ada WHERE adaid=?', PDO::FETCH_ASSOC);
         $pdo->query('SELECT email, adaid, gesperrt, freigabe1u1 FROM ada WHERE adaid=:adaid', PDO::FETCH_ASSOC);
     }
+
+    public function syntaxErrorPdoPrepare(PDO $pdo)
+    {
+        $pdo->prepare('SELECT email adaid WHERE gesperrt freigabe1u1 FROM ada');
+    }
 }