prevent wrong type inference on doctrine dbal 2.x (#151)

Co-authored-by: Markus Staab <[email protected]>

Author: staabm

composer.json

@@ -5,6 +5,8 @@
 	"require": {
 		"php": "^8.0",
 		"ext-mysqli": "*",
+		"composer-runtime-api": "^2.0",
+		"composer/semver": "^3.2",
 		"phpstan/phpstan": "^1.2"
 	},
 	"require-dev": {

src/Extensions/DoctrineConnectionDynamicReturnTypeExtension.php

@@ -4,6 +4,8 @@
 
 namespace staabm\PHPStanDba\Extensions;
 
+use Composer\InstalledVersions;
+use Composer\Semver\VersionParser;
 use Doctrine\DBAL\Connection;
 use Doctrine\DBAL\Result;
 use Doctrine\DBAL\Statement;
@@ -51,6 +53,11 @@ public function getTypeFromMethodCall(MethodReflection $methodReflection, Method
             return $defaultReturn;
         }
 
+        // make sure we don't report wrong types in doctrine 2.x
+        if (!InstalledVersions::satisfies(new VersionParser(), 'doctrine/dbal', '3.*')) {
+            return $defaultReturn;
+        }
+
         $resultType = $this->inferType($methodReflection, $args[0]->value, $scope);
         if (null !== $resultType) {
             return $resultType;

src/Extensions/DoctrineResultDynamicReturnTypeExtension.php

@@ -4,6 +4,8 @@
 
 namespace staabm\PHPStanDba\Extensions;
 
+use Composer\InstalledVersions;
+use Composer\Semver\VersionParser;
 use Doctrine\DBAL\Result;
 use PhpParser\Node\Expr\MethodCall;
 use PHPStan\Analyser\Scope;
@@ -37,8 +39,12 @@ public function getTypeFromMethodCall(MethodReflection $methodReflection, Method
     {
         $defaultReturn = ParametersAcceptorSelector::selectSingle($methodReflection->getVariants())->getReturnType();
 
-        $resultType = $scope->getType($methodCall->var);
+        // make sure we don't report wrong types in doctrine 2.x
+        if (!InstalledVersions::satisfies(new VersionParser(), 'doctrine/dbal', '3.*')) {
+            return $defaultReturn;
+        }
 
+        $resultType = $scope->getType($methodCall->var);
         if (!$resultType instanceof GenericObjectType) {
             return $defaultReturn;
         }