Refactoring (#266)

* Refactoring

* Update QuerySimulation.php

* Update QuerySimulation.php

* Update QuerySimulation.php

* Update QuerySimulation.php

Author: staabm

src/QueryReflection/MysqliQueryReflector.php

@@ -24,8 +24,6 @@ final class MysqliQueryReflector implements QueryReflector
 
     public const MYSQL_HOST_NOT_FOUND = 2002;
 
-    public const DATE_FORMAT = 'Y-m-d';
-
     private const MAX_CACHE_SIZE = 50;
 
     private mysqli $db;

src/QueryReflection/QuerySimulation.php

@@ -27,6 +27,8 @@
  */
 final class QuerySimulation
 {
+    public const DATE_FORMAT = 'Y-m-d';
+
     /**
      * @throws UnresolvableQueryException
      */
@@ -72,13 +74,18 @@ public static function simulateParamValueType(Type $paramType, bool $preparedPar
         }
 
         $stringType = new StringType();
-        if ($stringType->isSuperTypeOf($paramType)->yes() || $paramType instanceof ObjectType && $paramType->isInstanceOf(Stringable::class)->yes()) {
+        $isStringableObjectType = $paramType instanceof ObjectType
+            && $paramType->isInstanceOf(Stringable::class)->yes();
+        if (
+            $stringType->isSuperTypeOf($paramType)->yes()
+            || $isStringableObjectType
+        ) {
             // in a prepared context, regular strings are fine
             if (true === $preparedParam) {
                 // returns a string in date-format, so in case the simulated value is used against a date/datetime column
                 // we won't run into a sql error.
                 // XX in case we would have a proper sql parser, we could feed schema-type-dependent default values in case of strings.
-                return date(MysqliQueryReflector::DATE_FORMAT, 0);
+                return date(self::DATE_FORMAT, 0);
             }
 
             // plain string types can contain anything.. we cannot reason about it