Skip to content

Commit 1de3850

Browse files
author
Bartłomiej Nowak
committed
use not depracated Connection::executeQuery and Connection::executeStatement methods to validate queries syntax errors
1 parent 807b67f commit 1de3850

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

config/rules.neon

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,8 @@ services:
4646
- 'PDO::prepare#0'
4747
- 'mysqli::query#0'
4848
- 'mysqli::execute_query#0'
49+
- 'Doctrine\DBAL\Connection::executeQuery#0'
50+
- 'Doctrine\DBAL\Connection::executeStatement#0'
4951
- 'Doctrine\DBAL\Connection::query#0' # deprecated in doctrine
5052
- 'Doctrine\DBAL\Connection::exec#0' # deprecated in doctrine
5153

tests/rules/data/syntax-error-in-query-method.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,13 +79,13 @@ public function syntaxErrorPdoPrepare(PDO $pdo)
7979
public function syntaxErrorDoctrineDbal(\Doctrine\DBAL\Connection $conn)
8080
{
8181
$sql = 'SELECT email adaid WHERE gesperrt freigabe1u1 FROM ada';
82-
$conn->query($sql);
82+
$conn->executeQuery($sql);
8383
}
8484

8585
public function noErrorOnQueriesContainingPlaceholders(\Doctrine\DBAL\Connection $conn)
8686
{
8787
// errors in this scenario are reported by SyntaxErrorInPreparedStatementMethodRule only
88-
$conn->query('SELECT email, adaid, gesperrt, freigabe1u1 FROM ada WHERE adaid=?');
88+
$conn->executeQuery('SELECT email, adaid, gesperrt, freigabe1u1 FROM ada WHERE adaid=?');
8989
}
9090

9191
public function conditionalSyntaxError(PDO $pdo)

0 commit comments

Comments
 (0)