Support \Doctrine\DBAL\Connection->query() syntax error checking (#66)

Co-authored-by: Markus Staab <[email protected]>

Author: staabm

.phpstan-dba.cache

@@ -213,7 +213,6 @@
       'result' => 
       array (
         1 => NULL,
-        2 => NULL,
         3 => NULL,
       ),
     ),
@@ -1076,90 +1075,6 @@
           array (
           ),
         )),
-        2 => 
-        PHPStan\Type\Constant\ConstantArrayType::__set_state(array(
-           'keyType' => 
-          PHPStan\Type\UnionType::__set_state(array(
-             'types' => 
-            array (
-              0 => 
-              PHPStan\Type\Constant\ConstantIntegerType::__set_state(array(
-                 'value' => 0,
-              )),
-              1 => 
-              PHPStan\Type\Constant\ConstantIntegerType::__set_state(array(
-                 'value' => 1,
-              )),
-              2 => 
-              PHPStan\Type\Constant\ConstantIntegerType::__set_state(array(
-                 'value' => 2,
-              )),
-              3 => 
-              PHPStan\Type\Constant\ConstantIntegerType::__set_state(array(
-                 'value' => 3,
-              )),
-            ),
-          )),
-           'itemType' => 
-          PHPStan\Type\UnionType::__set_state(array(
-             'types' => 
-            array (
-              0 => 
-              PHPStan\Type\IntegerRangeType::__set_state(array(
-                 'min' => -128,
-                 'max' => 4294967295,
-              )),
-              1 => 
-              PHPStan\Type\StringType::__set_state(array(
-              )),
-            ),
-          )),
-           'allArrays' => NULL,
-           'keyTypes' => 
-          array (
-            0 => 
-            PHPStan\Type\Constant\ConstantIntegerType::__set_state(array(
-               'value' => 0,
-            )),
-            1 => 
-            PHPStan\Type\Constant\ConstantIntegerType::__set_state(array(
-               'value' => 1,
-            )),
-            2 => 
-            PHPStan\Type\Constant\ConstantIntegerType::__set_state(array(
-               'value' => 2,
-            )),
-            3 => 
-            PHPStan\Type\Constant\ConstantIntegerType::__set_state(array(
-               'value' => 3,
-            )),
-          ),
-           'valueTypes' => 
-          array (
-            0 => 
-            PHPStan\Type\StringType::__set_state(array(
-            )),
-            1 => 
-            PHPStan\Type\IntegerRangeType::__set_state(array(
-               'min' => 0,
-               'max' => 4294967295,
-            )),
-            2 => 
-            PHPStan\Type\IntegerRangeType::__set_state(array(
-               'min' => -128,
-               'max' => 127,
-            )),
-            3 => 
-            PHPStan\Type\IntegerRangeType::__set_state(array(
-               'min' => -128,
-               'max' => 127,
-            )),
-          ),
-           'nextAutoIndex' => 4,
-           'optionalKeys' => 
-          array (
-          ),
-        )),
       ),
     ),
     'SELECT email, adaid, gesperrt, freigabe1u1 FROM ada LIMIT 1' => 

composer.json

@@ -9,6 +9,7 @@
 	},
 	"require-dev": {
 		"ext-pdo": "*",
+		"doctrine/dbal": "^3.2",
 		"friendsofphp/php-cs-fixer": "3.4.0",
 		"phpstan/phpstan-php-parser": "^1.1",
 		"phpstan/phpstan-phpunit": "^1.0",
@@ -43,7 +44,10 @@
 		]
 	},
 	"config": {
-		"sort-packages": true
+		"sort-packages": true,
+		"allow-plugins": {
+			"composer/package-versions-deprecated": true
+		}
 	},
 	"extra": {
 		"phpstan": {

config/dba.neon

@@ -15,6 +15,7 @@ services:
 				- 'PDO::query#0'
 				- 'PDO::prepare#0'
 				- 'mysqli::query#0'
+				- 'Doctrine\DBAL\Connection::query#0'
 
 	-
 		class: staabm\PHPStanDba\Rules\SyntaxErrorInQueryFunctionRule

tests/SyntaxErrorInQueryMethodRuleTest.php

@@ -53,6 +53,10 @@ public function testSyntaxErrorInQueryRule(): void
                 "Query error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL/MariaDB server version for the right syntax to use near 'freigabe1u1 FROM ada LIMIT 0' at line 1 (1064).",
                 67,
             ],
+            [
+                "Query error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL/MariaDB server version for the right syntax to use near 'freigabe1u1 FROM ada LIMIT 0' at line 1 (1064).",
+                73,
+            ],
         ]);
     }
 }

tests/data/syntax-error-in-query.php

@@ -66,4 +66,10 @@ public function syntaxErrorPdoPrepare(PDO $pdo)
     {
         $pdo->prepare('SELECT email adaid WHERE gesperrt freigabe1u1 FROM ada');
     }
+
+    public function syntaxErrorDoctrineDbal(\Doctrine\DBAL\Connection $conn)
+    {
+        $sql = 'SELECT email adaid WHERE gesperrt freigabe1u1 FROM ada';
+        $stmt = $conn->query($sql);
+    }
 }