Update PdoStatementObjectType.php

staabm · staabm · commit 385e22611e50 · 2024-11-07T14:47:43.000+01:00
diff --git a/src/PdoReflection/PdoStatementObjectType.php b/src/PdoReflection/PdoStatementObjectType.php
@@ -147,6 +147,9 @@ public static function createDefaultType(int $fetchType): Type
         return self::newWithBothAndFetchType(new MixedType(), $fetchType);
     }
 
+    // differentiate objects based on the local properties,
+    // to make sure TypeCombinator::union() will not normalize separate objects away.
+    // this means we need to implement equals() and isSuperTypeOf() to compare the local properties.
     public function equals(Type $type): bool
     {
         if ($type instanceof self && $type->fetchType !== null && $type->bothType !== null) {

Original file line number	Diff line number	Diff line change
`@@ -147,6 +147,9 @@ public static function createDefaultType(int $fetchType): Type`
`147`	`147`	`return self::newWithBothAndFetchType(new MixedType(), $fetchType);`
`148`	`148`	`}`
`149`	`149`
	`150`	`+ // differentiate objects based on the local properties,`
	`151`	`+ // to make sure TypeCombinator::union() will not normalize separate objects away.`
	`152`	`+ // this means we need to implement equals() and isSuperTypeOf() to compare the local properties.`
`150`	`153`	`public function equals(Type $type): bool`
`151`	`154`	`{`
`152`	`155`	`if ($type instanceof self && $type->fetchType !== null && $type->bothType !== null) {`