Fix "Query expects 9223372036854775807-0 placeholders, but no values are given." (#629)

Author: staabm

src/QueryReflection/PlaceholderValidation.php

@@ -46,6 +46,10 @@ public function checkQuery(Expr $queryExpr, Scope $scope, array $parameters): it
             }
         }
 
+        if ($minPlaceholderCount === PHP_INT_MAX) {
+            $minPlaceholderCount = 0;
+        }
+
         yield from $this->validateUnnamedPlaceholders($parameters, $minPlaceholderCount, $maxPlaceholderCount);
     }
 

tests/rules/PdoStatementExecuteMethodRuleTest.php

@@ -125,6 +125,10 @@ public function testPlaceholderBug(): void
                 'Query expects 2-3 placeholders, but 1-3 values are given.',
                 42,
             ],
+            [
+                'Query expects 2 placeholders, but no values are given.',
+                48,
+            ],
         ]);
     }
 }

tests/rules/data/placeholder-bug.php

@@ -41,4 +41,10 @@ public function sometimesWrongNumberOfParameters(PDO $pdo, $vkFrom)
         $stmt = $pdo->prepare('SELECT email, adaid FROM ada WHERE adaid = ? OR adaid = ? ' . $fromCondition);
         $stmt->execute($values);
     }
+
+    public function wrongMinBound(PDO $pdo)
+    {
+        $stmt = $pdo->prepare('SELECT email, adaid FROM ada WHERE adaid = ? OR adaid = ? ');
+        $stmt->execute([]);
+    }
 }