Test PHP 7.2 in github action (#523)

Author: staabm

.github/workflows/phpstan.yml

@@ -76,9 +76,13 @@ jobs:
         with:
           composer-options: "--prefer-dist --no-progress"
 
-      - name: Install sqlftw/sqlftw
+      - name: Install sqlftw/sqlftw (optional dependency)
         run: composer require sqlftw/sqlftw --ignore-platform-req=php+
-        if: "${{matrix.php-version != '7.3'}}"
+        if: "${{matrix.php-version != '7.2' && matrix.php-version != '7.3'}}"
+
+      - name: Install doctrine/dbal (optional dependency)
+        run: composer require doctrine/dbal --ignore-platform-req=php+
+        if: "${{matrix.php-version != '7.2'}}"
 
       - name: Enable phpstan@dev
         if: "${{matrix.phpstan-version != ''}}"
@@ -127,8 +131,12 @@ jobs:
         with:
           composer-options: "--prefer-dist --no-progress"
 
-      - name: Install sqlftw/sqlftw
+      - name: Install sqlftw/sqlftw (optional dependency)
         run: composer require sqlftw/sqlftw --ignore-platform-req=php+
-        if: "${{matrix.php-version != '7.3'}}"
+        if: "${{matrix.php-version != '7.2' && matrix.php-version != '7.3'}}"
+
+      - name: Install doctrine/dbal (optional dependency)
+        run: composer require doctrine/dbal --ignore-platform-req=php+
+        if: "${{matrix.php-version != '7.2'}}"
 
       - run: composer phpstan

.github/workflows/tests-postgres.yml

@@ -53,9 +53,13 @@ jobs:
               with:
                 composer-options: "--prefer-dist --no-progress"
 
-            - name: Install sqlftw/sqlftw
+            - name: Install sqlftw/sqlftw (optional dependency)
               run: composer require sqlftw/sqlftw --ignore-platform-req=php+
-              if: "${{matrix.php-version != '7.3'}}"
+              if: "${{matrix.php-version != '7.2' && matrix.php-version != '7.3'}}"
+
+            - name: Install doctrine/dbal (optional dependency)
+              run: composer require doctrine/dbal --ignore-platform-req=php+
+              if: "${{matrix.php-version != '7.2'}}"
 
             - name: Setup Problem Matchers for PHPUnit
               run: echo "::add-matcher::${{ runner.tool_cache }}/phpunit.json"

.github/workflows/tests.yml

@@ -16,6 +16,10 @@ jobs:
       fail-fast: false
       matrix:
         include:
+          - php-version: "7.2"
+            db-image: 'mysql:5.7'
+            reflector: "pdo-mysql"
+            mode: "recording"
           - php-version: "7.3"
             db-image: 'mysql:5.7'
             reflector: "pdo-mysql"
@@ -96,9 +100,13 @@ jobs:
         # ignore php8.2 requirement error https://github.com/sebastianbergmann/phpunit/issues/5033
         composer-options: "--prefer-dist --no-progress --ignore-platform-req=php+"
 
-    - name: Install sqlftw/sqlftw
+    - name: Install sqlftw/sqlftw (optional dependency)
       run: composer require sqlftw/sqlftw --ignore-platform-req=php+
-      if: "${{matrix.php-version != '7.3'}}"
+      if: "${{matrix.php-version != '7.2' && matrix.php-version != '7.3'}}"
+
+    - name: Install doctrine/dbal (optional dependency)
+      run: composer require doctrine/dbal --ignore-platform-req=php+
+      if: "${{matrix.php-version != '7.2'}}"
 
     - name: Setup Problem Matchers for PHPUnit
       run: echo "::add-matcher::${{ runner.tool_cache }}/phpunit.json"
@@ -148,9 +156,13 @@ jobs:
         # ignore php8.2 requirement error https://github.com/sebastianbergmann/phpunit/issues/5033
         composer-options: "--prefer-dist --no-progress --ignore-platform-req=php+"
 
-    - name: Install sqlftw/sqlftw
+    - name: Install sqlftw/sqlftw (optional dependency)
       run: composer require sqlftw/sqlftw --ignore-platform-req=php+
-      if: "${{matrix.php-version != '7.3'}}"
+      if: "${{matrix.php-version != '7.2' && matrix.php-version != '7.3'}}"
+
+    - name: Install doctrine/dbal (optional dependency)
+      run: composer require doctrine/dbal --ignore-platform-req=php+
+      if: "${{matrix.php-version != '7.2'}}"
 
     - name: Setup Problem Matchers for PHPUnit
       run: echo "::add-matcher::${{ runner.tool_cache }}/phpunit.json"

composer.json

@@ -13,7 +13,6 @@
 		"ext-mysqli": "*",
 		"ext-pdo": "*",
 		"dibi/dibi": "^4.2",
-		"doctrine/dbal": "^2.13|^3.0",
 		"php-parallel-lint/php-parallel-lint": "^1.3",
 		"phpstan/extension-installer": "^1.2",
 		"phpstan/phpstan-php-parser": "^1.1",

tests/default/DbaInferenceTest.php

@@ -13,7 +13,14 @@ class DbaInferenceTest extends TypeInferenceTestCase
 {
     public function dataFileAsserts(): iterable
     {
-        yield from $this->gatherAssertTypes(__DIR__ . '/data/doctrine-dbal.php');
+        if (\PHP_VERSION_ID >= 70300) {
+            if (! InstalledVersions::isInstalled('doctrine/dbal')) {
+                throw new \Exception('doctrine/dbal 3.x is required to run tests for php 7.3+. Please install it via composer.');
+            }
+
+            yield from $this->gatherAssertTypes(__DIR__ . '/data/doctrine-dbal.php');
+            yield from $this->gatherAssertTypes(__DIR__ . '/data/inference-placeholder.php');
+        }
 
         // make sure class constants can be resolved
         require_once __DIR__ . '/data/pdo.php';
@@ -67,7 +74,6 @@ public function dataFileAsserts(): iterable
         yield from $this->gatherAssertTypes(__DIR__ . '/data/mysqli-union-result.php');
         yield from $this->gatherAssertTypes(__DIR__ . '/data/pdo-default-fetch-types.php');
         yield from $this->gatherAssertTypes(__DIR__ . '/data/bug372.php');
-        yield from $this->gatherAssertTypes(__DIR__ . '/data/inference-placeholder.php');
 
         if (\PHP_VERSION_ID >= 70400 && 'pdo-pgsql' !== getenv('DBA_REFLECTOR')) {
             yield from $this->gatherAssertTypes(__DIR__ . '/data/sql-ast-narrowing.php');

tests/rules/QueryPlanAnalyzerRuleTest.php

@@ -60,6 +60,10 @@ public function testNotUsingIndex(): void
             self::markTestSkipped('query plan analyzer requires a active database connection');
         }
 
+        if (\PHP_VERSION_ID < 70300) {
+            self::markTestSkipped('not yet supported on php < 7.3');
+        }
+
         $this->numberOfAllowedUnindexedReads = true;
         $this->numberOfRowsNotRequiringIndex = 2;
 
@@ -105,6 +109,10 @@ public function testNotUsingIndexInDebugMode(): void
             self::markTestSkipped('query plan analyzer requires a active database connection');
         }
 
+        if (\PHP_VERSION_ID < 70300) {
+            self::markTestSkipped('not yet supported on php < 7.3');
+        }
+
         $this->debugMode = true;
         $this->numberOfAllowedUnindexedReads = true;
         $this->numberOfRowsNotRequiringIndex = 2;