[cs] apply PSR-12 and other sets

Author: TomasVotruba

bootstrap.php

@@ -1,11 +1,13 @@
 <?php
 
+declare(strict_types=1);
+
 use Dotenv\Dotenv;
 use staabm\PHPStanDba\QueryReflection\QueryReflection;
 use staabm\PHPStanDba\QueryReflection\RuntimeConfiguration;
 use staabm\PHPStanDba\Tests\ReflectorFactory;
 
-require_once __DIR__.'/vendor/autoload.php';
+require_once __DIR__ . '/vendor/autoload.php';
 
 if (false === getenv('GITHUB_ACTION')) {
     $dotenv = Dotenv::createImmutable(__DIR__);

composer.json

@@ -43,7 +43,7 @@
 	},
 	"scripts": {
 		"csfix": [
-			"vendor/bin/ecs --ansi"
+			"vendor/bin/ecs --ansi --fix"
 		],
 		"test": [
 			"@putenv DBA_REFLECTOR=mysqli",

ecs.php

@@ -2,7 +2,6 @@
 
 declare(strict_types=1);
 
-use PhpCsFixer\Fixer\Import\NoUnusedImportsFixer;
 use Symplify\EasyCodingStandard\Config\ECSConfig;
 use Symplify\EasyCodingStandard\ValueObject\Set\SetList;
 
@@ -15,18 +14,18 @@
     ]);
 
     $ecsConfig->skip([
-        '*/data/*'
+        '*/data/*',
     ]);
 
     // this way you can add sets - group of rules
     $ecsConfig->sets([
         // run and fix, one by one
-         SetList::SPACES,
-         SetList::ARRAY,
-         SetList::STRICT,
-         SetList::DOCBLOCK,
-         SetList::NAMESPACES,
-         SetList::COMMENTS,
-         SetList::PSR_12,
+        SetList::SPACES,
+        SetList::ARRAY,
+        SetList::STRICT,
+        SetList::DOCBLOCK,
+        SetList::NAMESPACES,
+        SetList::COMMENTS,
+        SetList::PSR_12,
     ]);
 };

src/Analyzer/QueryPlanAnalyzer.php

@@ -13,10 +13,12 @@ final class QueryPlanAnalyzer
      * number of unindexed reads allowed before a query is considered inefficient.
      */
     public const DEFAULT_UNINDEXED_READS_THRESHOLD = 100000;
+
     /**
      * allows analyzing queries even on empty database schemas.
      */
     public const TABLES_WITHOUT_DATA = 0;
+
     /**
      * max number of rows in a table, for which we don't report errors, because using a index/table-scan wouldn't improve performance.
      * requires production quality data in the database at analysis time.

src/Analyzer/QueryPlanAnalyzerMysql.php

@@ -17,12 +17,14 @@ final class QueryPlanAnalyzerMysql
      * @deprecated use QueryPlanAnalyzer::DEFAULT_UNINDEXED_READS_THRESHOLD instead
      */
     public const DEFAULT_UNINDEXED_READS_THRESHOLD = QueryPlanAnalyzer::DEFAULT_UNINDEXED_READS_THRESHOLD;
+
     /**
      * @api
      *
      * @deprecated use QueryPlanAnalyzer::TABLES_WITHOUT_DATA instead
      */
     public const TABLES_WITHOUT_DATA = QueryPlanAnalyzer::TABLES_WITHOUT_DATA;
+
     /**
      * @api
      *
@@ -48,7 +50,7 @@ public function __construct($connection)
      */
     public function analyze(string $query): QueryPlanResult
     {
-        $simulatedQuery = 'EXPLAIN '.$query;
+        $simulatedQuery = 'EXPLAIN ' . $query;
 
         if ($this->connection instanceof PDO) {
             $this->connection->beginTransaction();

src/Analyzer/QueryPlanResult.php

@@ -7,7 +7,9 @@
 final class QueryPlanResult
 {
     public const NO_INDEX = 'no-index';
+
     public const TABLE_SCAN = 'table-scan';
+
     public const UNINDEXED_READS = 'unindexed-reads';
 
     /**
@@ -32,8 +34,6 @@ public function getSimulatedQuery(): string
 
     /**
      * @param self::* $result
-     *
-     * @return void
      */
     public function addRow(string $table, string $result)
     {

src/Ast/ExpressionFinder.php

@@ -138,7 +138,7 @@ private function findFirstPreviousOfNode(Node $node, callable $filter): ?Node
         // move to previous expression
         $previousStatement = $node->getAttribute(PreviousConnectingVisitor::ATTRIBUTE_PREVIOUS);
         if (null !== $previousStatement) {
-            if (!$previousStatement instanceof Node) {
+            if (! $previousStatement instanceof Node) {
                 throw new ShouldNotHappenException();
             }
             $foundNode = $this->findFirst([$previousStatement], $filter);

src/Ast/PreviousConnectingVisitor.php

@@ -4,13 +4,14 @@
 
 namespace staabm\PHPStanDba\Ast;
 
-use function array_pop;
 use PhpParser\Node;
 use PhpParser\NodeVisitorAbstract;
+use function array_pop;
 
 final class PreviousConnectingVisitor extends NodeVisitorAbstract
 {
     public const ATTRIBUTE_PARENT = 'dba-parent';
+
     public const ATTRIBUTE_PREVIOUS = 'dba-previous';
 
     /**

src/CacheNotPopulatedException.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace staabm\PHPStanDba;
 
 final class CacheNotPopulatedException extends DbaException

src/DbaException.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace staabm\PHPStanDba;
 
 class DbaException extends \RuntimeException