simplify PdoStatementExecuteTypeSpecifyingExtension (#259)

Co-authored-by: Markus Staab <[email protected]>

Author: staabm

src/Extensions/PdoStatementExecuteTypeSpecifyingExtension.php

@@ -42,14 +42,13 @@ public function specifyTypes(MethodReflection $methodReflection, MethodCall $nod
     {
         // keep original param name because named-parameters
         $methodCall = $node;
-        $stmtType = $scope->getType($methodCall->var);
 
         $inferedType = $this->inferStatementType($methodReflection, $methodCall, $scope);
         if (null !== $inferedType) {
             return $this->typeSpecifier->create($methodCall->var, $inferedType, TypeSpecifierContext::createTruthy(), true);
         }
 
-        return $this->typeSpecifier->create($methodCall->var, $stmtType, TypeSpecifierContext::createTruthy());
+        return new SpecifiedTypes();
     }
 
     private function inferStatementType(MethodReflection $methodReflection, MethodCall $methodCall, Scope $scope): ?Type

src/Extensions/PdoStatementFetchDynamicReturnTypeExtension.php

@@ -12,13 +12,9 @@
 use PHPStan\Reflection\MethodReflection;
 use PHPStan\Reflection\ParametersAcceptorSelector;
 use PHPStan\Type\ArrayType;
-use PHPStan\Type\Constant\ConstantArrayType;
-use PHPStan\Type\Constant\ConstantArrayTypeBuilder;
 use PHPStan\Type\Constant\ConstantBooleanType;
 use PHPStan\Type\Constant\ConstantIntegerType;
-use PHPStan\Type\Constant\ConstantStringType;
 use PHPStan\Type\DynamicMethodReturnTypeExtension;
-use PHPStan\Type\Generic\GenericObjectType;
 use PHPStan\Type\IntegerType;
 use PHPStan\Type\MixedType;
 use PHPStan\Type\Type;
@@ -85,7 +81,7 @@ private function inferType(MethodReflection $methodReflection, MethodCall $metho
 
         $pdoStatementReflection = new PdoStatementReflection();
         $resultType = $pdoStatementReflection->getStatementResultType($statementType, $fetchType);
-        if ($resultType === null) {
+        if (null === $resultType) {
             return null;
         }
 

src/PdoReflection/PdoStatementReflection.php

@@ -15,8 +15,6 @@
 use PHPStan\Type\Generic\GenericObjectType;
 use PHPStan\Type\Type;
 use staabm\PHPStanDba\QueryReflection\ExpressionFinder;
-use staabm\PHPStanDba\QueryReflection\QueryReflection;
-use staabm\PHPStanDba\QueryReflection\QueryReflector;
 
 final class PdoStatementReflection
 {
@@ -36,11 +34,14 @@ public function findPrepareQueryStringExpression(MethodReflection $methodReflect
     }
 
     /**
-     * // the following param doesnt work, see phpstan bug https://github.com/phpstan/phpstan/issues/6577
+     * // the following param doesnt work, see phpstan bug https://github.com/phpstan/phpstan/issues/6577.
+     *
      * @xx-param PDO::FETCH* $fetchType
+     *
      * @return Type|null
      */
-    public function getStatementResultType(Type $statementType, int $fetchType) {
+    public function getStatementResultType(Type $statementType, int $fetchType)
+    {
         if (!$statementType instanceof GenericObjectType) {
             return null;
         }