Don't hard error on incomplete query containing union-type (#27)

Co-authored-by: Markus Staab <[email protected]>

Author: staabm

.phpstan-dba.cache

@@ -132,45 +132,6 @@
         )),
       ),
     ),
-    'SELECT cmsdomainid FROM cmsdomain WHERE url ="" and standard=1' => 
-    array (
-      'error' => NULL,
-      'result' => 
-      array (
-        2 => 
-        PHPStan\Type\Constant\ConstantArrayType::__set_state(array(
-           'keyType' => 
-          PHPStan\Type\Constant\ConstantIntegerType::__set_state(array(
-             'value' => 0,
-          )),
-           'itemType' => 
-          PHPStan\Type\IntegerRangeType::__set_state(array(
-             'min' => -2147483648,
-             'max' => 2147483647,
-          )),
-           'keyTypes' => 
-          array (
-            0 => 
-            PHPStan\Type\Constant\ConstantIntegerType::__set_state(array(
-               'value' => 0,
-            )),
-          ),
-           'valueTypes' => 
-          array (
-            0 => 
-            PHPStan\Type\IntegerRangeType::__set_state(array(
-               'min' => -2147483648,
-               'max' => 2147483647,
-            )),
-          ),
-           'nextAutoIndex' => 1,
-           'optionalKeys' => 
-          array (
-          ),
-           'allArrays' => NULL,
-        )),
-      ),
-    ),
     'SELECT doesNotExist, adaid, gesperrt, freigabe1u1 FROM ada' => 
     array (
       'error' => 
@@ -468,18 +429,6 @@
         )),
       ),
     ),
-    'SELECT email, adaid, gesperrt, freigabe1u1 FROM  LIMIT 1' => 
-    array (
-      'error' => 
-      staabm\PHPStanDba\Error::__set_state(array(
-         'message' => 'You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near \'LIMIT 0\' at line 1',
-         'code' => 1064,
-      )),
-      'result' => 
-      array (
-        1 => NULL,
-      ),
-    ),
     'SELECT email, adaid, gesperrt, freigabe1u1 FROM ada' => 
     array (
       'error' => NULL,
@@ -861,18 +810,6 @@
         )),
       ),
     ),
-    'SELECT email, adaid, gesperrt, freigabe1u1 FROM ada WHERE ' => 
-    array (
-      'error' => 
-      staabm\PHPStanDba\Error::__set_state(array(
-         'message' => 'You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near \'LIMIT 0\' at line 1',
-         'code' => 1064,
-      )),
-      'result' => 
-      array (
-        1 => NULL,
-      ),
-    ),
     'SELECT email, adaid, gesperrt, freigabe1u1 FROM ada WHERE adaid=1' => 
     array (
       'error' => NULL,

src/QueryReflection/QueryReflection.php

@@ -15,6 +15,7 @@
 use PHPStan\Type\MixedType;
 use PHPStan\Type\StringType;
 use PHPStan\Type\Type;
+use PHPStan\Type\UnionType;
 use staabm\PHPStanDba\DbaException;
 use staabm\PHPStanDba\Error;
 
@@ -117,7 +118,7 @@ private function resolveQueryString(Expr $expr, Scope $scope): ?string
             return '1.0';
         }
 
-        if ($type instanceof MixedType || $type instanceof StringType || $type instanceof IntersectionType) {
+        if ($type instanceof MixedType || $type instanceof StringType || $type instanceof IntersectionType || $type instanceof UnionType) {
             return null;
         }
 

tests/data/syntax-error-in-query.php

@@ -46,6 +46,17 @@ public function incompleteQuery(PDO $pdo, string $tableName)
         $pdo->query('SELECT email, adaid, gesperrt, freigabe1u1 FROM '.$tableName.' LIMIT 1', PDO::FETCH_ASSOC);
     }
 
+    public function incompleteQueryUnion(PDO $pdo)
+    {
+        $add = '';
+        if (rand(0, 1)) {
+            $add .= 'my_other_table';
+        }
+
+        // XXX we might get smarter in query parsing and resolve this query at analysis time
+        $pdo->query('SELECT email, adaid, gesperrt, freigabe1u1 FROM ada .'.$add.' LIMIT 1', PDO::FETCH_ASSOC);
+    }
+
     public function validQuery(PDO $pdo)
     {
         $pdo->query('SELECT email, adaid, gesperrt, freigabe1u1 FROM ada', PDO::FETCH_ASSOC);