Skip to content

Commit 88dac16

Browse files
staabmclxmstaab
andauthored
No error on whitespace after trailling semicolon (#217)
Co-authored-by: Markus Staab <[email protected]>
1 parent c7936fd commit 88dac16

File tree

3 files changed

+14
-1
lines changed

3 files changed

+14
-1
lines changed

.phpunit-phpstan-dba.cache

Lines changed: 4 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/QueryReflection/QuerySimulation.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,10 @@ public static function simulate(string $queryString): ?string
105105

106106
private static function stripTraillingLimit(string $queryString): ?string
107107
{
108-
// XXX someday we will use a proper SQL parser,
108+
// XXX someday we will use a proper SQL parser
109+
$queryString = rtrim($queryString);
110+
111+
// strip trailling delimiting semicolon
109112
$queryString = rtrim($queryString, ';');
110113

111114
// strip trailling FOR UPDATE/FOR SHARE

tests/data/syntax-error-in-prepared-statement.php

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -306,4 +306,10 @@ public function conditionalNumberOfPlaceholders(Connection $connection, string $
306306

307307
$connection->preparedQuery($sql, $args);
308308
}
309+
310+
public function noErrorOnTraillingSemicolonAndWhitespace(Connection $connection)
311+
{
312+
$query = 'SELECT email, adaid, gesperrt, freigabe1u1 FROM ada; ';
313+
$connection->preparedQuery($query, []);
314+
}
309315
}

0 commit comments

Comments
 (0)