prevent unnecessary work in union type queries (#147)

Co-authored-by: Markus Staab <[email protected]>

Author: staabm

.phpunit-phpstan-dba.cache

@@ -2,6 +2,64 @@
   'schemaVersion' => 'v3-rename-props',
   'records' => 
   array (
+    '
+            SELECT email adaid
+            WHERE gesperrt = \'1\' AND email LIKE \'%@example.com\'
+            FROM ada
+            LIMIT        1
+        ' => 
+    array (
+      'error' => 
+      staabm\PHPStanDba\Error::__set_state(array(
+         'message' => 'You have an error in your SQL syntax; check the manual that corresponds to your MySQL/MariaDB server version for the right syntax to use near \'FROM ada LIMIT 0\' at line 3',
+         'code' => 1064,
+      )),
+    ),
+    '
+            SELECT email, adaid
+            FROM ada
+            WHERE gesperrt = \'1\'
+            LIMIT        \'1\'
+        ' => 
+    array (
+      'error' => NULL,
+    ),
+    '
+            SELECT email, adaid
+            FROM ada
+            WHERE gesperrt = \'1\'
+            LIMIT        \'1\',  \'1\'
+        ' => 
+    array (
+      'error' => NULL,
+    ),
+    '
+            SELECT email, adaid
+            FROM ada
+            WHERE gesperrt = \'1\'
+            LIMIT   \'1\',     \'1\'
+        ' => 
+    array (
+      'error' => NULL,
+    ),
+    '
+            SELECT email, adaid
+            FROM ada
+            WHERE gesperrt = \'1\' AND email LIKE \'%@example%\'
+            LIMIT        1
+        ' => 
+    array (
+      'error' => NULL,
+    ),
+    '
+            SELECT email, adaid
+            FROM ada
+            WHERE gesperrt = \'1\' AND email LIKE NULL
+            LIMIT        1
+        ' => 
+    array (
+      'error' => NULL,
+    ),
     '
             SELECT email adaid
             WHERE gesperrt = \'1\' AND email LIKE \'%@example.com\'
@@ -2717,6 +2775,11 @@ Simulated query: SELECT email, adaid FROM ada . WHERE email=\'my_other_table\' L
     array (
       'error' => NULL,
     ),
+    'SELECT email, adaid, gesperrt, freigabe1u1 FROM ada
+            WHERE (gesperrt=\'1\' AND freigabe1u1=1) OR (gesperrt=\'1\' AND freigabe1u1=0)' => 
+    array (
+      'error' => NULL,
+    ),
     'SELECT email, adaid, gesperrt, freigabe1u1 FROM ada  WHERE email=\'my_other_table\' LIMIT 1' => 
     array (
       'error' => NULL,

src/QueryReflection/QueryReflection.php

@@ -84,6 +84,8 @@ public function resolvePreparedQueryStrings(Expr $queryExpr, Type $parameterType
                 $queryString = $this->replaceParameters($queryString, $parameters);
                 yield $queryString;
             }
+
+            return;
         }
 
         $queryString = $this->resolvePreparedQueryString($queryExpr, $parameterTypes, $scope);
@@ -119,6 +121,8 @@ public function resolveQueryStrings(Expr $queryExpr, Scope $scope): iterable
             foreach (TypeUtils::getConstantStrings($type) as $constantString) {
                 yield $constantString->getValue();
             }
+
+            return;
         }
 
         $queryString = $this->resolveQueryString($queryExpr, $scope);
@@ -258,7 +262,7 @@ public function countPlaceholders(string $queryString): int
         if (preg_match_all(self::REGEX_UNNAMED_PLACEHOLDER, $queryString, $matches) > 0) {
             $candidates = $matches[0];
 
-            // filter placeholders within quotes strings
+            // filter placeholders within quoted strings
             $candidates = array_filter($candidates, function ($candidate) {
                 return '"' !== $candidate[0] && "'" !== $candidate[0];
             });
@@ -277,7 +281,7 @@ public function extractNamedPlaceholders(string $queryString): array
         if (preg_match_all(self::REGEX_NAMED_PLACEHOLDER, $queryString, $matches) > 0) {
             $candidates = $matches[0];
 
-            // filter placeholders within quotes strings
+            // filter placeholders within quoted strings
             $candidates = array_filter($candidates, function ($candidate) {
                 return '"' !== $candidate[0] && "'" !== $candidate[0];
             });