Report invalid query after simulation as unresolvable

Author: staabm

src/QueryReflection/QueryReflection.php

@@ -34,6 +34,7 @@
 use staabm\PHPStanDba\SchemaReflection\SchemaReflection;
 use staabm\PHPStanDba\SqlAst\ParserInference;
 use staabm\PHPStanDba\UnresolvableQueryException;
+use staabm\PHPStanDba\UnresolvableQueryInvalidAfterSimulationException;
 
 final class QueryReflection
 {
@@ -286,6 +287,10 @@ public function resolveQueryStrings(Expr $queryExpr, Scope $scope): iterable
             $error = $this->validateQueryString($normalizedQuery);
             if ($error === null) {
                 yield $normalizedQuery;
+            } else {
+                if (QueryReflection::getRuntimeConfiguration()->isDebugEnabled()) {
+                    throw new UnresolvableQueryInvalidAfterSimulationException('Seems the query is too dynamic to be resolved by query simulation');
+                }
             }
         }
     }

src/UnresolvableQueryInvalidAfterSimulationException.php

@@ -0,0 +1,16 @@
+<?php
+
+declare(strict_types=1);
+
+namespace staabm\PHPStanDba;
+
+/**
+ * @api
+ */
+final class UnresolvableQueryInvalidAfterSimulationException extends UnresolvableQueryException
+{
+    public static function getTip(): string
+    {
+        return 'Consider to simplify the query string construction.';
+    }
+}

tests/rules/UnresolvableQueryMethodRuleTest.php

@@ -8,6 +8,7 @@
 use PHPStan\Testing\RuleTestCase;
 use staabm\PHPStanDba\QueryReflection\QueryReflection;
 use staabm\PHPStanDba\Rules\SyntaxErrorInQueryMethodRule;
+use staabm\PHPStanDba\UnresolvableQueryInvalidAfterSimulationException;
 use staabm\PHPStanDba\UnresolvableQueryMixedTypeException;
 use staabm\PHPStanDba\UnresolvableQueryStringTypeException;
 
@@ -76,6 +77,12 @@ public function testBug548(): void
 
     public function testBug547(): void
     {
-        $this->analyse([__DIR__ . '/data/bug-547.php'], []);
+        $this->analyse([__DIR__ . '/data/bug-547.php'], [
+            [
+                'Unresolvable Query: Seems the query is too dynamic to be resolved by query simulation.',
+                10,
+                UnresolvableQueryInvalidAfterSimulationException::getTip(),
+            ],
+        ]);
     }
 }