prevent wrong type inference on queries containing string (#198)

Co-authored-by: Markus Staab <[email protected]>

Author: staabm

.phpstan-dba.cache

@@ -103,7 +103,7 @@ public function resolvePreparedQueryStrings(Expr $queryExpr, Type $parameterType
      */
     public function resolvePreparedQueryString(Expr $queryExpr, Type $parameterTypes, Scope $scope): ?string
     {
-        $queryString = $this->resolveQueryExpr($queryExpr, $scope, true);
+        $queryString = $this->resolveQueryExpr($queryExpr, $scope);
 
         if (null === $queryString) {
             return null;
@@ -134,7 +134,7 @@ public function resolveQueryStrings(Expr $queryExpr, Scope $scope): iterable
             return;
         }
 
-        $queryString = $this->resolveQueryExpr($queryExpr, $scope, false);
+        $queryString = $this->resolveQueryExpr($queryExpr, $scope);
         if (null !== $queryString) {
             yield $queryString;
         }
@@ -145,37 +145,37 @@ public function resolveQueryStrings(Expr $queryExpr, Scope $scope): iterable
      */
     public function resolveQueryString(Expr $queryExpr, Scope $scope): ?string
     {
-        return $this->resolveQueryExpr($queryExpr, $scope, false);
+        return $this->resolveQueryExpr($queryExpr, $scope);
     }
 
     /**
      * @throws UnresolvableQueryException
      */
-    private function resolveQueryExpr(Expr $queryExpr, Scope $scope, bool $preparedContext): ?string
+    private function resolveQueryExpr(Expr $queryExpr, Scope $scope): ?string
     {
         if ($queryExpr instanceof Expr\Variable) {
             $finder = new ExpressionFinder();
             $queryStringExpr = $finder->findQueryStringExpression($queryExpr);
 
             if (null !== $queryStringExpr) {
-                return $this->resolveQueryStringExpr($queryStringExpr, $scope, $preparedContext);
+                return $this->resolveQueryStringExpr($queryStringExpr, $scope);
             }
         }
 
-        return $this->resolveQueryStringExpr($queryExpr, $scope, $preparedContext);
+        return $this->resolveQueryStringExpr($queryExpr, $scope);
     }
 
     /**
      * @throws UnresolvableQueryException
      */
-    private function resolveQueryStringExpr(Expr $queryExpr, Scope $scope, bool $preparedContext): ?string
+    private function resolveQueryStringExpr(Expr $queryExpr, Scope $scope): ?string
     {
         if ($queryExpr instanceof Concat) {
             $left = $queryExpr->left;
             $right = $queryExpr->right;
 
-            $leftString = $this->resolveQueryStringExpr($left, $scope, $preparedContext);
-            $rightString = $this->resolveQueryStringExpr($right, $scope, $preparedContext);
+            $leftString = $this->resolveQueryStringExpr($left, $scope);
+            $rightString = $this->resolveQueryStringExpr($right, $scope);
 
             if (null === $leftString || null === $rightString) {
                 return null;
@@ -186,7 +186,7 @@ private function resolveQueryStringExpr(Expr $queryExpr, Scope $scope, bool $pre
 
         $type = $scope->getType($queryExpr);
 
-        return QuerySimulation::simulateParamValueType($type, $preparedContext);
+        return QuerySimulation::simulateParamValueType($type, false);
     }
 
     public static function getQueryType(string $query): ?string

.phpunit-phpstan-dba.cache

@@ -106,4 +106,20 @@ public function specifiedArray(PDO $pdo, array $idsToUpdate, string $time)
         ]);
         assertType('PDOStatement<array{adaid: int<0, 4294967295>, 0: int<0, 4294967295>}>', $stmt);
     }
+
+    public function noInferenceOnBug196(PDO $pdo, array $minorPhpVersions, \DateTimeImmutable $updateDate)
+    {
+        $sumQueries = [];
+        $dataPointDate = $updateDate->format('Ymd');
+        foreach ($minorPhpVersions as $index => $version) {
+            $sumQueries[] = 'SUM(DATA->\'$."'.$version.'"."'.$dataPointDate.'"\')';
+        }
+        $stmt = $pdo->prepare(
+            'SELECT '.implode(', ', $sumQueries).' FROM ada WHERE adaid = :package'
+        );
+        $stmt->execute(['package' => 'abc']);
+        // this query is too dynamic for beeing analyzed.
+        // make sure we don't infer a wrong type.
+        assertType('PDOStatement', $stmt);
+    }
 }