fixed error with placeholder in LIMIT clause (#99)

Co-authored-by: Markus Staab <[email protected]>

Author: staabm

.phpunit-phpstan-dba.cache

@@ -2,6 +2,55 @@
   'schemaVersion' => 'v3-rename-props',
   'records' => 
   array (
+    '
+            SELECT email adaid
+            WHERE gesperrt = \'1\' AND email LIKE \'%@example.com\'
+            FROM ada
+            LIMIT        1
+        ' => 
+    array (
+      'error' => 
+      staabm\PHPStanDba\Error::__set_state(array(
+         'message' => 'You have an error in your SQL syntax; check the manual that corresponds to your MySQL/MariaDB server version for the right syntax to use near \'FROM ada LIMIT 0\' at line 3',
+         'code' => 1064,
+      )),
+    ),
+    '
+            SELECT email, adaid
+            FROM ada
+            WHERE gesperrt = \'1\'
+            LIMIT        \'1\'
+        ' => 
+    array (
+      'error' => NULL,
+    ),
+    '
+            SELECT email, adaid
+            FROM ada
+            WHERE gesperrt = \'1\'
+            LIMIT        \'1\',  \'1\'
+        ' => 
+    array (
+      'error' => NULL,
+    ),
+    '
+            SELECT email, adaid
+            FROM ada
+            WHERE gesperrt = \'1\' AND email LIKE \'%@example%\'
+            LIMIT        1
+        ' => 
+    array (
+      'error' => NULL,
+    ),
+    '
+            SELECT email, adaid
+            FROM ada
+            WHERE gesperrt = \'1\' AND email LIKE NULL
+            LIMIT        1
+        ' => 
+    array (
+      'error' => NULL,
+    ),
     '
             SELECT email adaid
             WHERE gesperrt = \'1\' AND email LIKE \'%@example.com\'

src/QueryReflection/QuerySimulation.php

@@ -66,6 +66,8 @@ public static function simulate(string $queryString): ?string
 
     private static function stripTraillingLimit(string $queryString): ?string
     {
-        return preg_replace('/\s*LIMIT\s+\d+\s*(,\s*\d*)?$/i', '', $queryString);
+        // XXX someday we will use a proper SQL parser,
+        // which would also allow us to support even more complex expressions like SELECT .. LIMIT X, Y FOR UPDATE
+        return preg_replace('/\s*LIMIT\s+["\']?\d+["\']?\s*(,\s*["\']?\d*["\']?)?\s*$/i', '', $queryString);
     }
 }

tests/data/syntax-error-in-prepared-statement.php

@@ -44,6 +44,26 @@ public function noErrorOnMixedParams(Connection $connection, $unknownType)
         ', [1, $unknownType]);
     }
 
+    public function noErrorOnPlaceholderInLimit(Connection $connection, int $limit)
+    {
+        $connection->preparedQuery('
+            SELECT email, adaid
+            FROM ada
+            WHERE gesperrt = ?
+            LIMIT        ?
+        ', [1, $limit]);
+    }
+
+    public function noErrorOnPlaceholderInOffsetAndLimit(Connection $connection, int $offset, int $limit)
+    {
+        $connection->preparedQuery('
+            SELECT email, adaid
+            FROM ada
+            WHERE gesperrt = ?
+            LIMIT        ?,  ?
+        ', [1, $offset, $limit]);
+    }
+
     public function preparedParams(Connection $connection)
     {
         $connection->preparedQuery('SELECT email, adaid FROM ada WHERE gesperrt = ?', [1]);