cover more unresolvable-query cases (#167)

Co-authored-by: Markus Staab <[email protected]>

Author: staabm

src/QueryReflection/QuerySimulation.php

@@ -74,8 +74,13 @@ public static function simulateParamValueType(Type $paramType): ?string
             return null;
         }
 
+        // plain string types can contain anything.. we cannot reason about it
+        if ($paramType instanceof StringType) {
+            return null;
+        }
+
         // all types which we can't simulate and render a query unresolvable at analysis time
-        if ($paramType instanceof MixedType || $paramType instanceof StringType || $paramType instanceof IntersectionType) {
+        if ($paramType instanceof MixedType || $paramType instanceof IntersectionType) {
             if (QueryReflection::getRuntimeConfiguration()->isDebugEnabled()) {
                 throw new UnresolvableQueryException('Cannot simulate parameter value for type: '.$paramType->describe(VerbosityLevel::precise()));
             }

tests/data/unresolvable-pdo-statement.php

@@ -20,4 +20,16 @@ public function noErrorOnMixedQuery(PDO $pdo, $mixed)
         $stmt = $pdo->prepare($mixed);
         $stmt->execute([]);
     }
+
+    public function noErrorOnStringQuery(PDO $pdo, string $query)
+    {
+        $stmt = $pdo->prepare($query);
+        $stmt->execute([]);
+    }
+
+    public function noErrorOnStringAndParamsQuery(PDO $pdo, string $query, array $params)
+    {
+        $stmt = $pdo->prepare($query);
+        $stmt->execute($params);
+    }
 }

tests/data/unresolvable-query-in-function.php

@@ -23,4 +23,9 @@ public function noErrorOnMixedQuery(DbCredentials $dbCredentials, $mixed)
         // which don't know anything about the actual query
         \Deployer\runMysqlQuery($mixed, $dbCredentials);
     }
+
+    public function noErrorOnStringQuery(DbCredentials $dbCredentials, string $query)
+    {
+        \Deployer\runMysqlQuery($query, $dbCredentials);
+    }
 }

tests/data/unresolvable-query-in-method.php

@@ -23,4 +23,9 @@ public function noErrorOnMixedQuery(PDO $pdo, $mixed)
         // which don't know anything about the actual query
         $pdo->query($mixed);
     }
+
+    public function noErrorOnStringQuery(PDO $pdo, string $query)
+    {
+        $pdo->query($query);
+    }
 }

tests/data/unresolvable-statement.php

@@ -19,4 +19,9 @@ public function noErrorOnMixedQuery(Connection $connection, $mixed)
         // which don't know anything about the actual query
         $connection->preparedQuery($mixed, []);
     }
+
+    public function noErrorOnStringQuery(Connection $connection, string $string)
+    {
+        $connection->preparedQuery($string, []);
+    }
 }