support conditional errors in prepared statements

Author: clxmstaab

.phpunit-phpstan-dba.cache

@@ -2771,6 +2771,14 @@ Simulated query: SELECT email, adaid, gesperrt, freigabe1u1 FROM ada . WHERE ema
          'code' => 1064,
       )),
     ),
+    'SELECT email, adaid, gesperrt, freigabe1u1 FROM ada WHERE asdsa=\'1\'' => 
+    array (
+      'error' => 
+      staabm\PHPStanDba\Error::__set_state(array(
+         'message' => 'Unknown column \'asdsa\' in \'where clause\'',
+         'code' => 1054,
+      )),
+    ),
     'SELECT email, adaid, gesperrt, freigabe1u1 FROM ada WHERE asdsa=1' => 
     array (
       'error' => 
@@ -3001,5 +3009,9 @@ Simulated query: SELECT email, adaid, gesperrt, freigabe1u1 FROM ada . WHERE ema
         )),
       ),
     ),
+    'SELECT email, adaid, gesperrt, freigabe1u1 FROM ada WHERE gesperrt=\'1\'' => 
+    array (
+      'error' => NULL,
+    ),
   ),
 );

src/QueryReflection/QueryReflection.php

@@ -62,6 +62,32 @@ public function getResultType(string $queryString, int $fetchType): ?Type
         return self::reflector()->getResultType($queryString, $fetchType);
     }
 
+    /**
+     * @return iterable<string>
+     */
+    public function resolvePreparedQueryStrings(Expr $queryExpr, Type $parameterTypes, Scope $scope): iterable
+    {
+        $type = $scope->getType($queryExpr);
+
+        if ($type instanceof UnionType) {
+            $parameters = $this->resolveParameters($parameterTypes);
+            if (null === $parameters) {
+                return null;
+            }
+
+            foreach (TypeUtils::getConstantStrings($type) as $constantString) {
+                $queryString = $constantString->getValue();
+                $queryString = $this->replaceParameters($queryString, $parameters);
+                yield $queryString;
+            }
+        }
+
+        $queryString = $this->resolvePreparedQueryString($queryExpr, $parameterTypes, $scope);
+        if (null !== $queryString) {
+            yield $queryString;
+        }
+    }
+
     public function resolvePreparedQueryString(Expr $queryExpr, Type $parameterTypes, Scope $scope): ?string
     {
         $queryString = $this->resolveQueryString($queryExpr, $scope);

src/Rules/SyntaxErrorInPreparedStatementMethodRule.php

@@ -96,16 +96,14 @@ private function checkErrors(CallLike $callLike, Scope $scope): array
         $parameterTypes = $scope->getType($args[1]->value);
 
         $queryReflection = new QueryReflection();
-        $queryString = $queryReflection->resolvePreparedQueryString($queryExpr, $parameterTypes, $scope);
-        if (null === $queryString) {
-            return [];
-        }
+        foreach ($queryReflection->resolvePreparedQueryStrings($queryExpr, $parameterTypes, $scope) as $queryString) {
+            $error = $queryReflection->validateQueryString($queryString);
 
-        $error = $queryReflection->validateQueryString($queryString);
-        if (null !== $error) {
-            return [
-                RuleErrorBuilder::message('Query error: '.$error->getMessage().' ('.$error->getCode().').')->line($callLike->getLine())->build(),
-            ];
+            if (null !== $error) {
+                return [
+                    RuleErrorBuilder::message('Query error: '.$error->getMessage().' ('.$error->getCode().').')->line($callLike->getLine())->build(),
+                ];
+            }
         }
 
         return [];

tests/SyntaxErrorInPreparedStatementMethodRuleTest.php

@@ -49,6 +49,10 @@ public function testSyntaxErrorInQueryRule(): void
                 "Query error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL/MariaDB server version for the right syntax to use near 'freigabe1u1 FROM ada LIMIT 0' at line 1 (1064).",
                 107,
             ],
+            [
+                "Query error: Unknown column 'asdsa' in 'where clause' (1054).",
+                122,
+            ],
         ]);
     }
 }

tests/data/syntax-error-in-prepared-statement.php

@@ -106,4 +106,19 @@ public function syntaxErrorInDoctrineDbal(\Doctrine\DBAL\Connection $conn, $type
         $conn->executeCacheQuery('SELECT email adaid WHERE gesperrt freigabe1u1 FROM ada', [], $types, $qcp);
         $conn->executeStatement('SELECT email adaid WHERE gesperrt freigabe1u1 FROM ada', []);
     }
+
+    public function conditionalSyntaxError(Connection $connection)
+    {
+        $query = 'SELECT email, adaid, gesperrt, freigabe1u1 FROM ada';
+
+        if (rand(0, 1)) {
+            // valid condition
+            $query .= ' WHERE gesperrt=?';
+        } else {
+            // unknown column
+            $query .= ' WHERE asdsa=?';
+        }
+
+        $connection->preparedQuery($query, [1]);
+    }
 }

tests/data/syntax-error-in-query.php

@@ -88,7 +88,7 @@ public function noErrorOnQueriesContainingPlaceholders(\Doctrine\DBAL\Connection
         $conn->query('SELECT email, adaid, gesperrt, freigabe1u1 FROM ada WHERE adaid=?');
     }
 
-    public function conditionalSyntaxErrors(PDO $pdo)
+    public function conditionalSyntaxError(PDO $pdo)
     {
         $query = 'SELECT email, adaid, gesperrt, freigabe1u1 FROM ada';