Skip Rule* tests when not using MysqliReflector (#284)

Co-authored-by: Markus Staab <[email protected]>

Author: staabm

tests/ReflectorFactory.php

@@ -13,6 +13,7 @@ final class ReflectorFactory
 {
     public static function create(string $cacheFile): QueryReflector
     {
+        // handle defaults
         if (false !== getenv('GITHUB_ACTION')) {
             $host = getenv('DBA_HOST') ?: '127.0.0.1';
             $user = getenv('DBA_USER') ?: 'root';
@@ -27,6 +28,10 @@ public static function create(string $cacheFile): QueryReflector
 
         $mode = getenv('DBA_MODE') ?: 'recording';
         $reflector = getenv('DBA_REFLECTOR') ?: 'mysqli';
+
+        // make env vars available to tests, in case non are defined yet
+        putenv('DBA_REFLECTOR='.$reflector);
+
         if ('recording' === $mode) {
             if ('mysqli' === $reflector) {
                 $mysqli = @new mysqli($host, $user, $password, $dbname);

tests/rules/PdoStatementExecuteMethodRuleTest.php renamed to tests/rules/PdoStatementExecuteMethodRuleMysqliReflectorTest.php

@@ -9,7 +9,7 @@
 /**
  * @extends AbstractServiceAwareRuleTestCase<PdoStatementExecuteMethodRule>
  */
-class PdoStatementExecuteMethodRuleTest extends AbstractServiceAwareRuleTestCase
+class PdoStatementExecuteMethodRuleMysqliReflectorTest extends AbstractServiceAwareRuleTestCase
 {
     protected function getRule(): Rule
     {
@@ -18,6 +18,10 @@ protected function getRule(): Rule
 
     public function testParameterErrors(): void
     {
+        if ('mysqli' !== getenv('DBA_REFLECTOR')) {
+            $this->markTestSkipped('Only works with MysqliReflector');
+        }
+
         require_once __DIR__.'/data/pdo-stmt-execute-error.php';
 
         $this->analyse([__DIR__.'/data/pdo-stmt-execute-error.php'], [

tests/rules/SyntaxErrorInPreparedStatementMethodRuleTest.php renamed to tests/rules/SyntaxErrorInPreparedStatementMethodRuleMysqliReflectorTest.php

@@ -9,7 +9,7 @@
 /**
  * @extends AbstractServiceAwareRuleTestCase<SyntaxErrorInPreparedStatementMethodRule>
  */
-class SyntaxErrorInPreparedStatementMethodRuleTest extends AbstractServiceAwareRuleTestCase
+class SyntaxErrorInPreparedStatementMethodRuleMysqliReflectorTest extends AbstractServiceAwareRuleTestCase
 {
     protected function getRule(): Rule
     {
@@ -18,6 +18,10 @@ protected function getRule(): Rule
 
     public function testSyntaxErrorInQueryRule(): void
     {
+        if ('mysqli' !== getenv('DBA_REFLECTOR')) {
+            $this->markTestSkipped('Only works with MysqliReflector');
+        }
+
         require_once __DIR__.'/data/syntax-error-in-prepared-statement.php';
 
         $this->analyse([__DIR__.'/data/syntax-error-in-prepared-statement.php'], [

tests/rules/SyntaxErrorInPreparedStatementMethodSubclassedRuleTest.php renamed to tests/rules/SyntaxErrorInPreparedStatementMethodSubclassedRuleMysqliReflectorTest.php

@@ -9,7 +9,7 @@
 /**
  * @extends AbstractServiceAwareRuleTestCase<SyntaxErrorInPreparedStatementMethodRule>
  */
-class SyntaxErrorInPreparedStatementMethodSubclassedRuleTest extends AbstractServiceAwareRuleTestCase
+class SyntaxErrorInPreparedStatementMethodSubclassedRuleMysqliReflectorTest extends AbstractServiceAwareRuleTestCase
 {
     protected function getRule(): Rule
     {
@@ -18,6 +18,10 @@ protected function getRule(): Rule
 
     public function testSyntaxErrorInQueryRule(): void
     {
+        if ('mysqli' !== getenv('DBA_REFLECTOR')) {
+            $this->markTestSkipped('Only works with MysqliReflector');
+        }
+
         require_once __DIR__.'/data/syntax-error-in-method-subclassed.php';
 
         $this->analyse([__DIR__.'/data/syntax-error-in-method-subclassed.php'], [

tests/rules/SyntaxErrorInQueryFunctionRuleTest.php renamed to tests/rules/SyntaxErrorInQueryFunctionRuleMysqliReflectorTest.php

@@ -9,7 +9,7 @@
 /**
  * @extends AbstractServiceAwareRuleTestCase<SyntaxErrorInQueryFunctionRule>
  */
-class SyntaxErrorInQueryFunctionRuleTest extends AbstractServiceAwareRuleTestCase
+class SyntaxErrorInQueryFunctionRuleMysqliReflectorTest extends AbstractServiceAwareRuleTestCase
 {
     protected function getRule(): Rule
     {
@@ -18,6 +18,10 @@ protected function getRule(): Rule
 
     public function testSyntaxErrorInQueryRule(): void
     {
+        if ('mysqli' !== getenv('DBA_REFLECTOR')) {
+            $this->markTestSkipped('Only works with MysqliReflector');
+        }
+
         require_once __DIR__.'/data/syntax-error-in-query-function.php';
 
         $this->analyse([__DIR__.'/data/syntax-error-in-query-function.php'], [

tests/rules/SyntaxErrorInQueryMethodRuleTest.php renamed to tests/rules/SyntaxErrorInQueryMethodRuleMysqliReflectorTest.php

@@ -9,7 +9,7 @@
 /**
  * @extends AbstractServiceAwareRuleTestCase<SyntaxErrorInQueryMethodRule>
  */
-class SyntaxErrorInQueryMethodRuleTest extends AbstractServiceAwareRuleTestCase
+class SyntaxErrorInQueryMethodRuleMysqliReflectorTest extends AbstractServiceAwareRuleTestCase
 {
     protected function getRule(): Rule
     {
@@ -18,6 +18,10 @@ protected function getRule(): Rule
 
     public function testSyntaxErrorInQueryRule(): void
     {
+        if ('mysqli' !== getenv('DBA_REFLECTOR')) {
+            $this->markTestSkipped('Only works with MysqliReflector');
+        }
+
         require_once __DIR__.'/data/syntax-error-in-query-method.php';
 
         $this->analyse([__DIR__.'/data/syntax-error-in-query-method.php'], [

tests/rules/SyntaxErrorInQueryMethodSubclassedRuleTest.php renamed to tests/rules/SyntaxErrorInQueryMethodSubclassedRuleMysqliReflectorTest.php

@@ -9,7 +9,7 @@
 /**
  * @extends AbstractServiceAwareRuleTestCase<SyntaxErrorInQueryMethodRule>
  */
-class SyntaxErrorInQueryMethodSubclassedRuleTest extends AbstractServiceAwareRuleTestCase
+class SyntaxErrorInQueryMethodSubclassedRuleMysqliReflectorTest extends AbstractServiceAwareRuleTestCase
 {
     protected function getRule(): Rule
     {
@@ -18,6 +18,10 @@ protected function getRule(): Rule
 
     public function testSyntaxErrorInQueryRule(): void
     {
+        if ('mysqli' !== getenv('DBA_REFLECTOR')) {
+            $this->markTestSkipped('Only works with MysqliReflector');
+        }
+
         require_once __DIR__.'/data/syntax-error-in-method-subclassed.php';
 
         $this->analyse([__DIR__.'/data/syntax-error-in-method-subclassed.php'], [

tests/rules/UnresolvablePdoStatementRuleTest.php renamed to tests/rules/UnresolvablePdoStatementRuleMysqliReflectorTest.php

@@ -11,7 +11,7 @@
 /**
  * @extends AbstractServiceAwareRuleTestCase<PdoStatementExecuteMethodRule>
  */
-class UnresolvablePdoStatementRuleTest extends AbstractServiceAwareRuleTestCase
+class UnresolvablePdoStatementRuleMysqliReflectorTest extends AbstractServiceAwareRuleTestCase
 {
     protected function setUp(): void
     {
@@ -30,6 +30,10 @@ protected function getRule(): Rule
 
     public function testSyntaxErrorInQueryRule(): void
     {
+        if ('mysqli' !== getenv('DBA_REFLECTOR')) {
+            $this->markTestSkipped('Only works with MysqliReflector');
+        }
+
         require_once __DIR__.'/data/unresolvable-pdo-statement.php';
 
         $this->analyse([__DIR__.'/data/unresolvable-pdo-statement.php'], [

tests/rules/UnresolvablePreparedStatementRuleTest.php renamed to tests/rules/UnresolvablePreparedStatementRuleMysqliReflectorTest.php

@@ -11,7 +11,7 @@
 /**
  * @extends AbstractServiceAwareRuleTestCase<SyntaxErrorInPreparedStatementMethodRule>
  */
-class UnresolvablePreparedStatementRuleTest extends AbstractServiceAwareRuleTestCase
+class UnresolvablePreparedStatementRuleMysqliReflectorTest extends AbstractServiceAwareRuleTestCase
 {
     protected function setUp(): void
     {
@@ -30,6 +30,10 @@ protected function getRule(): Rule
 
     public function testSyntaxErrorInQueryRule(): void
     {
+        if ('mysqli' !== getenv('DBA_REFLECTOR')) {
+            $this->markTestSkipped('Only works with MysqliReflector');
+        }
+
         require_once __DIR__.'/data/unresolvable-statement.php';
 
         $this->analyse([__DIR__.'/data/unresolvable-statement.php'], [

tests/rules/UnresolvableQueryFunctionRuleTest.php renamed to tests/rules/UnresolvableQueryFunctionRuleMysqliReflectorTest.php

@@ -11,7 +11,7 @@
 /**
  * @extends AbstractServiceAwareRuleTestCase<SyntaxErrorInQueryFunctionRule>
  */
-class UnresolvableQueryFunctionRuleTest extends AbstractServiceAwareRuleTestCase
+class UnresolvableQueryFunctionRuleMysqliReflectorTest extends AbstractServiceAwareRuleTestCase
 {
     protected function setUp(): void
     {
@@ -30,6 +30,10 @@ protected function getRule(): Rule
 
     public function testSyntaxErrorInQueryRule(): void
     {
+        if ('mysqli' !== getenv('DBA_REFLECTOR')) {
+            $this->markTestSkipped('Only works with MysqliReflector');
+        }
+
         require_once __DIR__.'/data/unresolvable-query-in-function.php';
 
         $this->analyse([__DIR__.'/data/unresolvable-query-in-function.php'], [