error on from table-name create from function-call (#459)

Author: staabm

tests/rules/data/syntax-error-in-prepared-statement.php

@@ -351,4 +351,14 @@ public function testInvalidDeleteUpdateInsert(Connection $conn)
         ]);
     }
 
+    /**
+     * @return string|false
+     */
+    private function returnsUnion() {}
+
+    public function bug458(Connection $conn)
+    {
+        $table = $this->returnsUnion();
+        $conn->executeQuery('SELECT * FROM ' . $table . ' LIMIT 1');
+    }
 }

tests/rules/data/syntax-error-in-query-function.php

@@ -43,4 +43,15 @@ public function bug442(\mysqli $mysqli, string $table)
     {
         mysqli_query($mysqli, "SELECT * FROM `$table`");
     }
+
+    /**
+     * @return string|false
+     */
+    private function returnsUnion() {}
+
+    public function bug458(\mysqli $mysqli)
+    {
+        $table = $this->returnsUnion();
+        mysqli_query($mysqli,'SELECT * FROM ' . $table . ' LIMIT 1');
+    }
 }

tests/rules/data/syntax-error-in-query-method.php

@@ -138,4 +138,15 @@ public function testInvalidDeleteUpdateInsert(PDO $pdo)
         $pdo->query('REPLACE into adasfd SET email="sdf"');
     }
 
+    /**
+     * @return string|false
+     */
+    private function returnsUnion() {}
+
+    public function bug458(PDO $pdo)
+    {
+        $table = $this->returnsUnion();
+        $pdo->query('SELECT * FROM ' . $table . ' LIMIT 1');
+    }
+
 }