doctrine-dbal: fetchAssociative() and fetchNumeric() both can return false (#195)

Co-authored-by: Markus Staab <[email protected]>

Author: staabm

src/Extensions/DoctrineConnectionFetchDynamicReturnTypeExtension.php

@@ -12,11 +12,13 @@
 use PHPStan\Analyser\Scope;
 use PHPStan\Reflection\MethodReflection;
 use PHPStan\Reflection\ParametersAcceptorSelector;
+use PHPStan\Type\Constant\ConstantBooleanType;
 use PHPStan\Type\DynamicMethodReturnTypeExtension;
 use PHPStan\Type\Generic\GenericObjectType;
 use PHPStan\Type\IntegerType;
 use PHPStan\Type\MixedType;
 use PHPStan\Type\Type;
+use PHPStan\Type\TypeCombinator;
 use staabm\PHPStanDba\QueryReflection\QueryReflection;
 use staabm\PHPStanDba\QueryReflection\QueryReflector;
 use Traversable;
@@ -93,6 +95,9 @@ private function inferType(MethodReflection $methodReflection, Expr $queryExpr,
                 return new GenericObjectType(Traversable::class, [new IntegerType(), $resultType]);
             }
 
+            // false is returned if no rows are found.
+            $resultType = TypeCombinator::union($resultType, new ConstantBooleanType(false));
+
             return $resultType;
         }
 

tests/data/doctrine-dbal.php

@@ -56,14 +56,14 @@ public function fetchAssociative(Connection $conn)
     {
         $query = 'SELECT email, adaid, gesperrt, freigabe1u1 FROM ada WHERE adaid = ?';
         $fetchResult = $conn->fetchAssociative($query, [1]);
-        assertType('array{email: string, adaid: int<0, 4294967295>, gesperrt: int<-128, 127>, freigabe1u1: int<-128, 127>}', $fetchResult);
+        assertType('array{email: string, adaid: int<0, 4294967295>, gesperrt: int<-128, 127>, freigabe1u1: int<-128, 127>}|false', $fetchResult);
     }
 
     public function fetchNumeric(Connection $conn)
     {
         $query = 'SELECT email, adaid, gesperrt, freigabe1u1 FROM ada WHERE adaid = ?';
         $fetchResult = $conn->fetchNumeric($query, [1]);
-        assertType('array{string, int<0, 4294967295>, int<-128, 127>, int<-128, 127>}', $fetchResult);
+        assertType('array{string, int<0, 4294967295>, int<-128, 127>, int<-128, 127>}|false', $fetchResult);
     }
 
     public function iterateAssociative(Connection $conn)