don't error on unknown types (#89)

Co-authored-by: Markus Staab <[email protected]>

Author: staabm

phpstan.neon.dist

@@ -19,6 +19,9 @@ parameters:
         -
             message: '#.*has no return type specified.#'
             path: tests/*
+        -
+            message: '#.*with no type specified.#'
+            path: tests/*
         -
             message: '#.*return type has no value type specified in iterable type iterable.#'
             path: tests/*

src/QueryReflection/MysqliQueryReflector.php

@@ -76,16 +76,15 @@ public function validateQueryString(string $queryString): ?Error
             return null;
         } catch (mysqli_sql_exception $e) {
             if (\in_array($e->getCode(), [self::MYSQL_SYNTAX_ERROR_CODE, self::MYSQL_UNKNOWN_COLUMN_IN_FIELDLIST, self::MYSQL_UNKNOWN_TABLE], true)) {
-
                 $message = $e->getMessage();
 
                 // make error string consistent across mysql/mariadb
                 $message = str_replace(' MySQL server', ' MySQL/MariaDB server', $message);
                 $message = str_replace(' MariaDB server', ' MySQL/MariaDB server', $message);
 
                 // to ease debugging, print the error we simulated
-                if ($e->getCode() === self::MYSQL_SYNTAX_ERROR_CODE && QueryReflection::getRuntimeConfiguration()->isDebugEnabled()) {
-                    $message = $message ."\n\nSimulated query: ". $simulatedQuery;
+                if (self::MYSQL_SYNTAX_ERROR_CODE === $e->getCode() && QueryReflection::getRuntimeConfiguration()->isDebugEnabled()) {
+                    $message = $message."\n\nSimulated query: ".$simulatedQuery;
                 }
 
                 return new Error($message, $e->getCode());

src/QueryReflection/QueryReflection.php

@@ -168,10 +168,14 @@ public function resolveParameters(Type $parameterTypes): ?array
 
                     if ($valueTypes[$i] instanceof ConstantScalarType) {
                         $parameters[$placeholderName] = $valueTypes[$i]->getValue();
+                    } else {
+                        return null;
                     }
                 } elseif ($keyType instanceof ConstantIntegerType) {
                     if ($valueTypes[$i] instanceof ConstantScalarType) {
                         $parameters[$keyType->getValue()] = $valueTypes[$i]->getValue();
+                    } else {
+                        return null;
                     }
                 }
             }

src/QueryReflection/RuntimeConfiguration.php

@@ -42,7 +42,8 @@ public function debugMode(bool $mode): self
         return $this;
     }
 
-    public function isDebugEnabled():bool {
+    public function isDebugEnabled(): bool
+    {
         return $this->debugMode;
     }
 

src/Rules/SyntaxErrorInPreparedStatementMethodRule.php

@@ -8,14 +8,12 @@
 use PhpParser\Node\Expr\CallLike;
 use PhpParser\Node\Expr\MethodCall;
 use PhpParser\Node\Expr\New_;
-use PhpParser\Node\Name;
 use PhpParser\Node\Name\FullyQualified;
 use PHPStan\Analyser\Scope;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleError;
 use PHPStan\Rules\RuleErrorBuilder;
 use PHPStan\Type\ObjectType;
-use Prophecy\Call\Call;
 use staabm\PHPStanDba\QueryReflection\QueryReflection;
 
 /**
@@ -83,6 +81,7 @@ public function processNode(Node $callLike, Scope $scope): array
 
     /**
      * @param MethodCall|New_ $callLike
+     *
      * @return RuleError[]
      */
     private function checkErrors(CallLike $callLike, Scope $scope): array

tests/data/syntax-error-in-prepared-statement.php

@@ -17,6 +17,16 @@ public function syntaxErrorInConstruct()
         $stmt = new PreparedStatement('SELECT email adaid WHERE gesperrt freigabe1u1 FROM ada', []);
     }
 
+    public function noErrorOnMixedParams(Connection $connection, $unknownType)
+    {
+        $connection->preparedQuery('
+            SELECT email, adaid
+            FROM ada
+            WHERE gesperrt = ? AND email LIKE ?
+            LIMIT        1
+        ', [1, $unknownType]);
+    }
+
     public function preparedParams(Connection $connection)
     {
         $connection->preparedQuery('SELECT email, adaid FROM ada WHERE gesperrt = ?', [1]);