Merge separate PDO and Mysqli rule tests (#410)

Co-authored-by: Pavel Karfik <[email protected]>

Author: p4veI

src/QueryReflection/MysqliQueryReflector.php

@@ -23,6 +23,8 @@ final class MysqliQueryReflector implements QueryReflector, RecordingReflector
 
     public const MYSQL_HOST_NOT_FOUND = 2002;
 
+    public const NAME = 'mysqli';
+
     private const MYSQL_ERROR_CODES = [
         self::MYSQL_SYNTAX_ERROR_CODE,
         self::MYSQL_UNKNOWN_COLUMN_IN_FIELDLIST,

src/QueryReflection/PdoMysqlQueryReflector.php

@@ -19,6 +19,8 @@
  */
 class PdoMysqlQueryReflector extends BasePdoQueryReflector
 {
+    public const NAME = 'pdo-mysql';
+
     public function __construct(PDO $pdo)
     {
         $pdo->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION);

src/QueryReflection/PdoPgSqlQueryReflector.php

@@ -17,6 +17,8 @@
  */
 final class PdoPgSqlQueryReflector extends BasePdoQueryReflector
 {
+    public const NAME = 'pdo-pgsql';
+
     public function __construct(PDO $pdo)
     {
         $typeMapper = new PgsqlTypeMapper();

tests/rules/SyntaxErrorInPreparedStatementMethodSubclassedRuleMysqliReflectorTest.php

@@ -0,0 +1,106 @@
+<?php
+
+namespace staabm\PHPStanDba\Tests;
+
+use PHPStan\Rules\Rule;
+use PHPStan\Testing\RuleTestCase;
+use staabm\PHPStanDba\QueryReflection\MysqliQueryReflector;
+use staabm\PHPStanDba\QueryReflection\PdoMysqlQueryReflector;
+use staabm\PHPStanDba\QueryReflection\PdoPgSqlQueryReflector;
+use staabm\PHPStanDba\Rules\SyntaxErrorInPreparedStatementMethodRule;
+
+/**
+ * @extends RuleTestCase<SyntaxErrorInPreparedStatementMethodRule>
+ */
+class SyntaxErrorInPreparedStatementMethodSubclassedRuleTest extends RuleTestCase
+{
+    protected function getRule(): Rule
+    {
+        return self::getContainer()->getByType(SyntaxErrorInPreparedStatementMethodRule::class);
+    }
+
+    public static function getAdditionalConfigFiles(): array
+    {
+        return [
+            __DIR__.'/config/subclassed-method-rule.neon',
+        ];
+    }
+
+    public function testSyntaxErrorInQueryRule(): void
+    {
+        if (\PHP_VERSION_ID < 70400) {
+            self::markTestSkipped('Test requires PHP 7.4.');
+        }
+
+        require_once __DIR__.'/data/syntax-error-in-method-subclassed.php';
+
+        $this->analyse([__DIR__.'/data/syntax-error-in-method-subclassed.php'], $this->getExpectedErrors());
+    }
+
+    /** @return list<array{string, int}> */
+    public function getExpectedErrors(): array
+    {
+        $dbaReflector = getenv('DBA_REFLECTOR');
+
+        switch ($dbaReflector) {
+            case MysqliQueryReflector::NAME:
+                return [
+                    [
+                        "Query error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL/MariaDB server version for the right syntax to use near 'with syntax error GROUPY by x LIMIT 0' at line 1 (1064).",
+                        12,
+                    ],
+                    [
+                        "Query error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL/MariaDB server version for the right syntax to use near 'freigabe1u1 FROM ada LIMIT 0' at line 1 (1064).",
+                        18,
+                    ],
+                    [
+                        "Query error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL/MariaDB server version for the right syntax to use near 'FROM ada LIMIT 0' at line 3 (1064).",
+                        20,
+                    ],
+                ];
+            case PdoPgSqlQueryReflector::NAME:
+                return [
+                    [
+                        <<<TEXT
+    Query error: SQLSTATE[42601]: Syntax error: 7 ERROR:  syntax error at or near "with"
+    LINE 1: SELECT with syntax error GROUPY by x LIMIT 0
+                   ^ (42601).
+    TEXT,
+                        12,
+                    ],
+                    [
+                        <<<TEXT
+    Query error: SQLSTATE[42601]: Syntax error: 7 ERROR:  syntax error at or near "freigabe1u1"
+    LINE 1: SELECT email adaid WHERE gesperrt freigabe1u1 FROM ada LIMIT...
+                                              ^ (42601).
+    TEXT,
+                        18,
+                    ],
+                    [
+                        <<<TEXT
+    Query error: SQLSTATE[42601]: Syntax error: 7 ERROR:  syntax error at or near "FROM"
+    LINE 3:             FROM ada LIMIT 0
+                        ^ (42601).
+    TEXT,
+                        20,
+                    ],
+                ];
+            case PdoMysqlQueryReflector::NAME:
+                return [
+                    [
+                        "Query error: SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL/MariaDB server version for the right syntax to use near 'with syntax error GROUPY by x LIMIT 0' at line 1 (42000).",
+                        12,
+                    ],
+                    [
+                        "Query error: SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL/MariaDB server version for the right syntax to use near 'freigabe1u1 FROM ada LIMIT 0' at line 1 (42000).",
+                        18,
+                    ],
+                    [
+                        "Query error: SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL/MariaDB server version for the right syntax to use near 'FROM ada LIMIT 0' at line 3 (42000).",
+                        20,
+                    ],
+                ];
+            default: throw new \RuntimeException(sprintf('Unsupported DBA_REFLECTOR %s', $dbaReflector));
+        }
+    }
+}