extracted DBA_MODE constants (#540)

Author: staabm

tests/ReflectorFactory.php

@@ -18,6 +18,12 @@
 
 final class ReflectorFactory
 {
+    public const MODE_RECORDING = 'recording';
+
+    public const MODE_REPLAY = 'replay';
+
+    public const MODE_REPLAY_AND_RECORDING = 'replay-and-recording';
+
     public static function create(string $cacheDir): QueryReflector
     {
         // handle defaults
@@ -26,7 +32,7 @@ public static function create(string $cacheDir): QueryReflector
             $user = getenv('DBA_USER') ?: 'root';
             $password = getenv('DBA_PASSWORD') ?: 'root';
             $dbname = getenv('DBA_DATABASE') ?: 'phpstan_dba';
-            $mode = getenv('DBA_MODE') ?: 'recording';
+            $mode = getenv('DBA_MODE') ?: self::MODE_RECORDING;
             $reflector = getenv('DBA_REFLECTOR') ?: 'mysqli';
         } else {
             $host = getenv('DBA_HOST') ?: $_ENV['DBA_HOST'];
@@ -61,7 +67,7 @@ public static function create(string $cacheDir): QueryReflector
             $cacheFile
         );
 
-        if ('recording' === $mode || 'replay-and-recording' === $mode) {
+        if (self::MODE_RECORDING === $mode || self::MODE_REPLAY_AND_RECORDING === $mode) {
             $schemaHasher = null;
 
             if ('mysqli' === $reflector) {
@@ -79,7 +85,7 @@ public static function create(string $cacheDir): QueryReflector
                 throw new \RuntimeException('Unknown reflector: ' . $reflector);
             }
 
-            if ('replay-and-recording' === $mode) {
+            if (self::MODE_REPLAY_AND_RECORDING === $mode) {
                 if (null === $schemaHasher) {
                     throw new \RuntimeException('Schema hasher required.');
                 }
@@ -95,7 +101,7 @@ public static function create(string $cacheDir): QueryReflector
                     $reflector
                 );
             }
-        } elseif ('replay' === $mode) {
+        } elseif (self::MODE_REPLAY === $mode) {
             $reflector = new ReplayQueryReflector(
                 $reflectionCache
             );

tests/rules/QueryPlanAnalyzerRuleTest.php

@@ -58,7 +58,7 @@ public function testNotUsingIndex(): void
             self::markTestSkipped('query plan analyzer is not yet implemented for pgsql');
         }
 
-        if ('recording' !== getenv('DBA_MODE')) {
+        if (ReflectorFactory::MODE_RECORDING !== getenv('DBA_MODE')) {
             self::markTestSkipped('query plan analyzer requires a active database connection');
         }
 
@@ -107,7 +107,7 @@ public function testNotUsingIndexInDebugMode(): void
             self::markTestSkipped('query plan analyzer is not yet implemented for pgsql');
         }
 
-        if ('recording' !== getenv('DBA_MODE')) {
+        if (ReflectorFactory::MODE_RECORDING !== getenv('DBA_MODE')) {
             self::markTestSkipped('query plan analyzer requires a active database connection');
         }