support mysqli_execute_query (php 8.2+ only) (#425)

Author: staabm

config/dba.neon

@@ -46,6 +46,7 @@ services:
                 - 'PDO::query#0'
                 - 'PDO::prepare#0'
                 - 'mysqli::query#0'
+                - 'mysqli::execute_query#0'
                 - 'Doctrine\DBAL\Connection::query#0' # deprecated in doctrine
                 - 'Doctrine\DBAL\Connection::exec#0' # deprecated in doctrine
 
@@ -56,6 +57,7 @@ services:
             functionNames:
                 - 'Deployer\runMysqlQuery#0'
                 - 'mysqli_query#1'
+                - 'mysqli_execute_query#1'
 
     -
         class: staabm\PHPStanDba\Rules\QueryPlanAnalyzerRule
@@ -84,5 +86,6 @@ services:
                 - 'PDO::query#0'
                 - 'PDO::prepare#0'
                 - 'mysqli::query#0'
+                - 'mysqli::execute_query#0'
                 - 'Doctrine\DBAL\Connection::query#0' # deprecated in doctrine
                 - 'Doctrine\DBAL\Connection::exec#0' # deprecated in doctrine

tests/default/config/phpstan.neon.dist

@@ -12,14 +12,9 @@ parameters:
         - bootstrap.php
 
     ignoreErrors:
-        - '#Function Deployer\\runMysqlQuery\(\) should return array<int, array<int, string>>\|null but return statement is missing.#'
         - '#.*has no return type specified.#'
         - '#.*return type has no value type specified in iterable type iterable.#'
-        - '#.*with no value type specified in iterable type array.#'
 
     excludePaths:
-        analyseAndScan:
-            - *Fixture/**
-            - */tests/default/data/pdo-pgsql.php
-            # XXX cases which are not yet supported by the PdoQueryReflector
-            - */tests/default/data/query-alias.php
+        - *Fixture/**
+        - *tests/*/data/**

tests/defaultFetchAssoc/config/phpstan.neon.dist

@@ -11,10 +11,9 @@ parameters:
     bootstrapFiles:
         - bootstrap.php
 
+    excludePaths:
+        - *Fixture/**
+        - *tests/*/data/**
+
     ignoreErrors:
-        - '#.*has no return type specified.#'
         - '#.*return type has no value type specified in iterable type iterable.#'
-
-    excludePaths:
-        analyseAndScan:
-            - *Fixture/**

tests/defaultFetchNumeric/config/phpstan.neon.dist

@@ -8,13 +8,12 @@ parameters:
     paths:
         - ../
 
+    excludePaths:
+        - *Fixture/**
+        - *tests/*/data/**
+
     bootstrapFiles:
         - bootstrap.php
 
     ignoreErrors:
-        - '#.*has no return type specified.#'
         - '#.*return type has no value type specified in iterable type iterable.#'
-
-    excludePaths:
-        analyseAndScan:
-            - *Fixture/**

tests/rules/SyntaxErrorInQueryFunctionRuleTest.php

@@ -103,4 +103,18 @@ public function getExpectedErrors(): array
             default: throw new \RuntimeException(sprintf('Unsupported DBA_REFLECTOR %s', $dbaReflector));
         }
     }
+
+    public function testMysqliExecuteQuery(): void
+    {
+        if (\PHP_VERSION_ID < 80200) {
+            self::markTestSkipped('Test requires PHP 8.2.');
+        }
+
+        $this->analyse([__DIR__.'/data/mysqli_execute_query.php'], [
+            [
+                "Query error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL/MariaDB server version for the right syntax to use near 'freigabe1u1 FROM ada LIMIT 0' at line 1 (1064).",
+                11,
+            ],
+        ]);
+    }
 }

tests/rules/config/phpstan.neon.dist

@@ -8,10 +8,12 @@ parameters:
     paths:
         - ../
 
+    excludePaths:
+        - *Fixture/**
+        - *tests/*/data/**
+
     bootstrapFiles:
         - bootstrap.php
 
     ignoreErrors:
         - '#.*has no return type specified.#'
-        - '#.*with no type specified.#'
-        - '#.*with no value type specified in iterable type array.#'

tests/rules/data/mysqli_execute_query.php

@@ -0,0 +1,13 @@
+<?php
+
+namespace MysqliExecuteQuery;
+
+class Foo
+{
+    public function syntaxError(\mysqli $mysqli)
+    {
+        $mysqli->execute_query('SELECT email adaid WHERE gesperrt freigabe1u1 FROM ada');
+
+        mysqli_execute_query($mysqli, 'SELECT email adaid WHERE gesperrt freigabe1u1 FROM ada');
+    }
+}

tests/stringify/config/phpstan.neon.dist

@@ -8,13 +8,12 @@ parameters:
     paths:
         - ../
 
+    excludePaths:
+        - *Fixture/**
+        - *tests/*/data/**
+
     bootstrapFiles:
         - bootstrap.php
 
     ignoreErrors:
-        - '#.*has no return type specified.#'
         - '#.*return type has no value type specified in iterable type iterable.#'
-
-    excludePaths:
-        analyseAndScan:
-            - *Fixture/**