simplify SyntaxError Rules (#77)

Co-authored-by: Markus Staab <[email protected]>

Author: staabm

src/Rules/SyntaxErrorInQueryFunctionRule.php

@@ -71,19 +71,20 @@ public function processNode(Node $node, Scope $scope): array
         }
 
         $args = $node->getArgs();
-        $errors = [];
 
         $queryReflection = new QueryReflection();
         $queryString = $queryReflection->resolveQueryString($args[$queryArgPosition]->value, $scope);
         if (null === $queryString) {
-            return $errors;
+            return [];
         }
 
         $error = $queryReflection->validateQueryString($queryString);
         if (null !== $error) {
-            $errors[] = RuleErrorBuilder::message('Query error: '.$error->getMessage().' ('.$error->getCode().').')->line($node->getLine())->build();
+            return [
+                RuleErrorBuilder::message('Query error: '.$error->getMessage().' ('.$error->getCode().').')->line($node->getLine())->build()
+            ];
         }
 
-        return $errors;
+        return [];
     }
 }

src/Rules/SyntaxErrorInQueryMethodRule.php

@@ -63,19 +63,21 @@ public function processNode(Node $node, Scope $scope): array
         }
 
         $args = $node->getArgs();
-        $errors = [];
 
         $queryReflection = new QueryReflection();
         $queryString = $queryReflection->resolveQueryString($args[$queryArgPosition]->value, $scope);
         if (null === $queryString) {
-            return $errors;
+            return [];
         }
 
         $error = $queryReflection->validateQueryString($queryString);
         if (null !== $error) {
-            $errors[] = RuleErrorBuilder::message('Query error: '.$error->getMessage().' ('.$error->getCode().').')->line($node->getLine())->build();
+            return [
+                RuleErrorBuilder::message('Query error: '.$error->getMessage().' ('.$error->getCode().').')->line($node->getLine())->build()
+            ];
+
         }
 
-        return $errors;
+        return [];
     }
 }