refactor: remove wayWarnings and other checks

1. We want to let the user take control and we have no issue with GHC failing
later on.
2. These checks depend on the compiler which now can change within the build
graph. If they have to exist they will exist in a different way.

Author: andreabedini

cabal-install/src/Distribution/Client/ProjectPlanning.hs

@@ -179,7 +179,6 @@ import Distribution.Simple.LocalBuildInfo
   , pkgComponents
   )
 
-import Distribution.Simple.BuildWay
 import Distribution.Simple.PackageIndex (InstalledPackageIndex)
 import Distribution.Simple.Program
 import Distribution.Simple.Program.Db
@@ -215,8 +214,6 @@ import qualified Distribution.InstalledPackageInfo as IPI
 import qualified Distribution.PackageDescription as PD
 import qualified Distribution.PackageDescription.Configuration as PD
 import qualified Distribution.Simple.Configure as Cabal
-import qualified Distribution.Simple.GHC as GHC
-import qualified Distribution.Simple.GHCJS as GHCJS
 import qualified Distribution.Simple.InstallDirs as InstallDirs
 import qualified Distribution.Simple.LocalBuildInfo as Cabal
 import qualified Distribution.Simple.Setup as Cabal
@@ -1677,8 +1674,7 @@ elaborateInstallPlan
                 (map fst src_comps)
             let whyNotPerComp = why_not_per_component src_comps
             case NE.nonEmpty whyNotPerComp of
-              Nothing -> do
-                elaborationWarnings
+              Nothing ->                
                 return comps
               Just notPerCompReasons -> do
                 checkPerPackageOk comps notPerCompReasons
@@ -1751,7 +1747,7 @@ elaborateInstallPlan
                   <+> fsep (punctuate comma $ map (text . whyNotPerComponent) $ toList reasons)
           -- TODO: Maybe exclude Backpack too
 
-          (elab0, elaborationWarnings) = elaborateSolverToCommon spkg
+          elab0 = elaborateSolverToCommon spkg
           pkgid = elabPkgSourceId elab0
           pd = elabPkgDescription elab0
 
@@ -2062,10 +2058,9 @@ elaborateInstallPlan
           -- Knot tying: the final elab includes the
           -- pkgInstalledId, which is calculated by hashing many
           -- of the other fields of the elaboratedPackage.
-          elaborationWarnings
           return elab
           where
-            (elab0@ElaboratedConfiguredPackage{..}, elaborationWarnings) =
+            elab0@ElaboratedConfiguredPackage{..} =
               elaborateSolverToCommon pkg
 
             elab1 =
@@ -2151,7 +2146,7 @@ elaborateInstallPlan
 
       elaborateSolverToCommon
         :: SolverPackage UnresolvedPkgLoc
-        -> (ElaboratedConfiguredPackage, LogProgress ())
+        -> ElaboratedConfiguredPackage
       elaborateSolverToCommon
         pkg@( SolverPackage
                 (SourcePackage pkgid gdesc srcloc descOverride)
@@ -2160,7 +2155,7 @@ elaborateInstallPlan
                 deps0
                 _exe_deps0
               ) =
-          (elaboratedPackage, wayWarnings pkgid)
+          elaboratedPackage
           where
             elaboratedPackage = ElaboratedConfiguredPackage{..}
 
@@ -2268,14 +2263,14 @@ elaborateInstallPlan
             elabBuildOptions =
               LBC.BuildOptions
                 { withVanillaLib = perPkgOptionFlag pkgid True packageConfigVanillaLib -- TODO: [required feature]: also needs to be handled recursively
-                , withSharedLib = canBuildSharedLibs && pkgid `Set.member` pkgsUseSharedLibrary
+                , withSharedLib = pkgid `Set.member` pkgsUseSharedLibrary
                 , withStaticLib = perPkgOptionFlag pkgid False packageConfigStaticLib
                 , withDynExe = perPkgOptionFlag pkgid False packageConfigDynExe
                 , withFullyStaticExe = perPkgOptionFlag pkgid False packageConfigFullyStaticExe
                 , withGHCiLib = perPkgOptionFlag pkgid False packageConfigGHCiLib -- TODO: [required feature] needs to default to enabled on windows still
                 , withProfExe = perPkgOptionFlag pkgid False packageConfigProf
-                , withProfLib = canBuildProfilingLibs && pkgid `Set.member` pkgsUseProfilingLibrary
-                , withProfLibShared = canBuildProfilingSharedLibs && pkgid `Set.member` pkgsUseProfilingLibraryShared
+                , withProfLib = pkgid `Set.member` pkgsUseProfilingLibrary
+                , withProfLibShared = pkgid `Set.member` pkgsUseProfilingLibraryShared
                 , exeCoverage = perPkgOptionFlag pkgid False packageConfigCoverage
                 , libCoverage = perPkgOptionFlag pkgid False packageConfigCoverage
                 , withOptimization = perPkgOptionFlag pkgid NormalOptimisation packageConfigOptimization
@@ -2437,77 +2432,29 @@ elaborateInstallPlan
         packagesWithLibDepsDownwardClosedProperty needsSharedLib
 
       needsSharedLib pkgid =
-        fromMaybe
-          compilerShouldUseSharedLibByDefault
-          -- Case 1: --enable-shared or --disable-shared is passed explicitly, honour that.
-          ( case pkgSharedLib of
-              Just v -> Just v
-              Nothing -> case pkgDynExe of
-                -- case 2: If --enable-executable-dynamic is passed then turn on
-                -- shared library generation.
-                Just True ->
-                  -- Case 3: If --enable-profiling is passed, then we are going to
-                  -- build profiled dynamic, so no need for shared libraries.
-                  case pkgProf of
-                    Just True -> if canBuildProfilingSharedLibs then Nothing else Just True
-                    _ -> Just True
-                -- But don't necessarily turn off shared library generation if
-                -- --disable-executable-dynamic is passed. The shared objects might
-                -- be needed for something different.
-                _ -> Nothing
-          )
-        where
-          pkgSharedLib = perPkgOptionMaybe pkgid packageConfigSharedLib
-          pkgDynExe = perPkgOptionMaybe pkgid packageConfigDynExe
-          pkgProf = perPkgOptionMaybe pkgid packageConfigProf
-
-      -- TODO: [code cleanup] move this into the Cabal lib. It's currently open
-      -- coded in Distribution.Simple.Configure, but should be made a proper
-      -- function of the Compiler or CompilerInfo.
-      compilerShouldUseSharedLibByDefault =
-        case compilerFlavor compiler of
-          GHC -> GHC.compilerBuildWay compiler == DynWay && canBuildSharedLibs
-          GHCJS -> GHCJS.isDynamic compiler
-          _ -> False
-
-      compilerShouldUseProfilingLibByDefault =
-        case compilerFlavor compiler of
-          GHC -> GHC.compilerBuildWay compiler == ProfWay && canBuildProfilingLibs
-          _ -> False
-
-      compilerShouldUseProfilingSharedLibByDefault =
-        case compilerFlavor compiler of
-          GHC -> GHC.compilerBuildWay compiler == ProfDynWay && canBuildProfilingSharedLibs
-          _ -> False
-
-      -- Returns False if we definitely can't build shared libs
-      canBuildWayLibs predicate = case predicate compiler of
-        Just can_build -> can_build
-        -- If we don't know for certain, just assume we can
-        -- which matches behaviour in previous cabal releases
-        Nothing -> True
-
-      canBuildSharedLibs = canBuildWayLibs dynamicSupported
-      canBuildProfilingLibs = canBuildWayLibs profilingVanillaSupported
-      canBuildProfilingSharedLibs = canBuildWayLibs profilingDynamicSupported
-
-      wayWarnings pkg = do
-        when
-          (needsProfilingLib pkg && not canBuildProfilingLibs)
-          (warnProgress (text "Compiler does not support building p libraries, profiling is disabled"))
-        when
-          (needsSharedLib pkg && not canBuildSharedLibs)
-          (warnProgress (text "Compiler does not support building dyn libraries, dynamic libraries are disabled"))
-        when
-          (needsProfilingLibShared pkg && not canBuildProfilingSharedLibs)
-          (warnProgress (text "Compiler does not support building p_dyn libraries, profiling dynamic libraries are disabled."))
+          fromFlagOrDefault False (case1 <> case2)
+          where
+            -- Case 1: --enable-shared or --disable-shared is passed explicitly, honour that.
+            case1 = pkgSharedLib
+            -- Case 2: --enable-executable-dynamic + --enable-profiling
+            -- turn on shared profiling libraries
+            case2 = case (pkgDynExe, pkgProf) of
+                      (Flag True, Flag True) -> Flag True
+                      _ -> NoFlag
+            -- FIXME
+            -- Case 3: If --enable-profiling is passed, then we are going to
+            -- build profiled dynamic, so no need for shared libraries.
+
+            pkgSharedLib = lookupPerPkgOption pkgid packageConfigSharedLib
+            pkgDynExe = lookupPerPkgOption pkgid packageConfigDynExe
+            pkgProf = lookupPerPkgOption pkgid packageConfigProf    
 
       pkgsUseProfilingLibrary :: Set PackageId
       pkgsUseProfilingLibrary =
         packagesWithLibDepsDownwardClosedProperty needsProfilingLib
 
       needsProfilingLib pkg =
-        fromFlagOrDefault compilerShouldUseProfilingLibByDefault (profBothFlag <> profLibFlag)
+        fromFlagOrDefault False (profBothFlag <> profLibFlag)
         where
           pkgid = packageId pkg
           profBothFlag = lookupPerPkgOption pkgid packageConfigProf
@@ -2518,28 +2465,21 @@ elaborateInstallPlan
         packagesWithLibDepsDownwardClosedProperty needsProfilingLibShared
 
       needsProfilingLibShared pkg =
-        fromMaybe
-          compilerShouldUseProfilingSharedLibByDefault
+        fromFlagOrDefault False $
           -- case 1: If --enable-profiling-shared is passed explicitly, honour that
-          ( case profLibSharedFlag of
-              Just v -> Just v
-              Nothing -> case pkgDynExe of
-                Just True ->
-                  case pkgProf of
-                    -- case 2: --enable-executable-dynamic + --enable-profiling
-                    -- turn on shared profiling libraries
-                    Just True -> if canBuildProfilingSharedLibs then Just True else Nothing
-                    _ -> Nothing
-                -- But don't necessarily turn off shared library generation is
-                -- --disable-executable-dynamic is passed. The shared objects might
-                -- be needed for something different.
-                _ -> Nothing
-          )
+          case profLibSharedFlag of
+            Flag True -> Flag True
+            _ ->
+              -- case 2: --enable-executable-dynamic + --enable-profiling
+              -- turn on shared profiling libraries
+              case pkgDynExe <> pkgProf of
+                Flag True -> Flag True
+                _ -> NoFlag
         where
           pkgid = packageId pkg
-          profLibSharedFlag = perPkgOptionMaybe pkgid packageConfigProfShared
-          pkgDynExe = perPkgOptionMaybe pkgid packageConfigDynExe
-          pkgProf = perPkgOptionMaybe pkgid packageConfigProf
+          profLibSharedFlag = lookupPerPkgOption pkgid packageConfigProfShared
+          pkgDynExe = lookupPerPkgOption pkgid packageConfigDynExe
+          pkgProf = lookupPerPkgOption pkgid packageConfigProf
 
       -- TODO: [code cleanup] unused: the old deprecated packageConfigProfExe