Skip to content

Commit 7f1bb37

Browse files
committed
Improve documentation
1 parent b69d9cf commit 7f1bb37

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

.github/scripts/test.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ cabal update
2727

2828
# TODO: we want to avoid building here... we should just
2929
# be using the previously built 'cabal-tests' binary
30+
# Also see https://github.com/haskell/cabal/issues/11048
3031
cabal run -w "ghc-${GHC_VERSION}" ${ADD_CABAL_ARGS} cabal-testsuite:cabal-tests -- \
3132
--with-cabal "$(pwd)/out/cabal" \
3233
--with-ghc "ghc-${GHC_TEST_VERSION}" \

.github/workflows/reusable-release.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -384,6 +384,7 @@ jobs:
384384
- name: install windows deps
385385
shell: pwsh
386386
run: |
387+
# https://www.msys2.org/docs/updating/
387388
C:\msys64\usr\bin\bash -lc "pacman --disable-download-timeout --noconfirm -Syuu"
388389
C:\msys64\usr\bin\bash -lc "pacman --disable-download-timeout --noconfirm -Syuu"
389390
C:\msys64\usr\bin\bash -lc "pacman --disable-download-timeout --noconfirm -S make mingw-w64-x86_64-clang curl autoconf mingw-w64-x86_64-pkgconf ca-certificates base-devel gettext autoconf make libtool automake python p7zip patch unzip zip git"
@@ -554,6 +555,9 @@ jobs:
554555
with:
555556
ref: ${{ matrix.branch }}
556557

558+
# Test suite uses 'git' to find the test files. That appears
559+
# to cause problems in CI. A similar hack is employed in the validate
560+
# pipeline.
557561
- name: git clone fix
558562
run: git config --system --add safe.directory $GITHUB_WORKSPACE
559563

@@ -575,6 +579,7 @@ jobs:
575579
DISTRO: ${{ matrix.platform.DISTRO }}
576580
ADD_CABAL_ARGS: ${{ matrix.platform.ADD_CABAL_ARGS }}
577581

582+
# TODO: https://github.com/haskell/cabal/issues/11049
578583
# test-linux-32bit:
579584
# name: Test linux binaries (32bit)
580585
# runs-on: ubuntu-latest

0 commit comments

Comments
 (0)