fix: Require processing:* properties on providers

Author: l0b0

package.json

@@ -2,12 +2,15 @@
   "name": "stac-extensions",
   "version": "1.0.0",
   "scripts": {
-    "test": "npm run check-markdown && npm run check-examples",
+    "test": "npx ospec && npm run check-markdown && npm run check-examples",
     "check-markdown": "remark . -f -r .github/remark.yaml",
     "check-examples": "stac-node-validator . --lint --verbose --schemaMap https://stac-extensions.github.io/processing/v1.0.0/schema.json=./json-schema/schema.json",
     "format-examples": "stac-node-validator . --format --schemaMap https://stac-extensions.github.io/processing/v1.0.0/schema.json=./json-schema/schema.json"
   },
+  "type": "module",
   "dependencies": {
+    "@types/ospec": "^4.0.2",
+    "ospec": "^4.1.1",
     "remark-cli": "^8.0.0",
     "remark-lint": "^7.0.0",
     "remark-lint-no-html": "^2.0.0",

tests/template_collection.test.js

@@ -0,0 +1,59 @@
+import o from 'ospec';
+import Ajv from 'ajv';
+import { join } from 'path';
+import { promises as fs } from 'fs';
+import { AjvOptions, rootDirectory, schemaPath } from './validation.js';
+
+const examplePath = join(rootDirectory, 'examples/collection.json');
+
+const propertyNames = [
+  'processing:expression',
+  'processing:facility',
+  'processing:level',
+  'processing:lineage',
+  'processing:software',
+];
+
+o.spec('Collection', () => {
+  let validate;
+  const ajv = new Ajv(AjvOptions);
+
+  o.before(async () => {
+    const data = JSON.parse(await fs.readFile(schemaPath));
+    validate = await ajv.compileAsync(data);
+  });
+
+  o('Example should pass validation', async () => {
+    // given
+    const example = JSON.parse(await fs.readFile(examplePath));
+
+    // when
+    let valid = validate(example);
+
+    // then
+    o(valid).equals(true)(JSON.stringify(validate.errors, null, 2));
+  });
+
+  o("Example without any provider processing: values should fail validation", async () => {
+    // given
+    const example = JSON.parse(await fs.readFile(examplePath));
+    for (const propertyName of propertyNames) {
+      delete example['providers'][0][propertyName];
+    }
+
+    // when
+    let valid = validate(example);
+
+    // then
+    o(valid).equals(false);
+    for (const propertyName of propertyNames) {
+      o(
+        validate.errors.some(
+          (error) =>
+            error.dataPath === ".providers[0]" &&
+            error.message === `should have required property '['${propertyName}']'`,
+        ),
+      ).equals(true)(JSON.stringify(validate.errors));
+    }
+  });
+});

tests/validation.js

@@ -0,0 +1,32 @@
+import axios from 'axios';
+import { dirname, join } from 'path';
+import { fileURLToPath } from 'url';
+import iriFormats from 'stac-node-validator/iri.js';
+
+const directory = dirname(fileURLToPath(import.meta.url));
+
+const Schemas = new Map();
+export function loadSchema(uri) {
+  let existing = Schemas.get(uri);
+  if (existing == null) {
+    existing = loadSchemaFromUri(uri);
+    Schemas.set(uri, existing);
+  }
+  return existing;
+}
+
+/**
+ * function passed in to Ajv instance which allows us to load schemas from a url at run time.
+ */
+export async function loadSchemaFromUri(uri) {
+  try {
+    let response = await axios.get(uri);
+    return response.data;
+  } catch (error) {
+    throw new Error(`-- Schema at '${uri}' not found. Please ensure all entries in 'stac_extensions' are valid.`);
+  }
+}
+
+export const AjvOptions = { loadSchema, formats: Object.assign(iriFormats) };
+export const rootDirectory = dirname(directory);
+export const schemaPath = join(rootDirectory, 'json-schema/schema.json');