fix: query in get requests

Author: gadomski

pystac_client/item_search.py

@@ -328,7 +328,11 @@ def _clean_params_for_get_request(self) -> Dict[str, Any]:
         if "collections" in params:
             params["collections"] = ",".join(params["collections"])
         if "intersects" in params:
-            params["intersects"] = json.dumps(params["intersects"])
+            params["intersects"] = json.dumps(
+                params["intersects"], separators=(",", ":")
+            )
+        if "query" in params:
+            params["query"] = json.dumps(params["query"], separators=(",", ":"))
         if "sortby" in params:
             params["sortby"] = self._sortby_dict_to_str(params["sortby"])
         if "fields" in params:

pystac_client/stac_api_io.py

@@ -154,8 +154,6 @@ def request(
             request = Request(method=method, url=href, headers=headers, json=parameters)
         else:
             params = deepcopy(parameters) or {}
-            if "intersects" in params:
-                params["intersects"] = json.dumps(params["intersects"])
             request = Request(method="GET", url=href, headers=headers, params=params)
         try:
             modified = self._req_modifier(request) if self._req_modifier else None

tests/test_item_search.py

@@ -8,6 +8,7 @@
 import requests
 from dateutil.tz import gettz, tzutc
 from pytest_benchmark.fixture import BenchmarkFixture
+from requests_mock import Mocker
 
 from pystac_client import Client
 from pystac_client.item_search import ItemSearch
@@ -619,6 +620,23 @@ def __geo_interface__(self) -> Dict[str, Any]:
         new_results = search.items()
         assert all(isinstance(item, pystac.Item) for item in new_results)
 
+    def test_get_with_query(self, requests_mock: Mocker) -> None:
+        requests_mock.get(
+            (
+                f"{SEARCH_URL}?query=%7B%22eo%3Acloud_cover%22%3A%7B%22gte%22%3A0%2C%22lte%22%3A10%7D%7D"
+            ),
+            status_code=200,
+            json={"features": [{"foo": "bar"}], "links": []},
+        )
+        items = list(
+            ItemSearch(
+                url=SEARCH_URL,
+                method="GET",
+                query={"eo:cloud_cover": {"gte": 0, "lte": 10}},
+            ).items_as_dicts()
+        )
+        assert len(items) == 1
+
     @pytest.mark.vcr
     def test_result_paging(self) -> None:
         search = ItemSearch(