Make pystac pass User-Agent to work around urllib being blocked

Author: jsignell

pystac/stac_io.py

@@ -302,12 +302,14 @@ def read_text_from_href(self, href: str) -> str:
                     with urllib3.request(
                         "GET",
                         href,
-                        headers=self.headers,
+                        headers={"User-Agent": "pystac", **self.headers},
                         preload_content=False,  # type: ignore
                     ) as f:
                         href_contents = f.read().decode("utf-8")
                 else:
-                    req = Request(href, headers=self.headers)
+                    req = Request(
+                        href, headers={"User-Agent": "pystac", **self.headers}
+                    )
                     with urlopen(req) as f:
                         href_contents = f.read().decode("utf-8")
 

tests/test_stac_io.py

@@ -130,7 +130,7 @@ def test_headers_stac_io(request_mock: unittest.mock.MagicMock) -> None:
     pystac.Catalog.from_file("https://example.com/catalog.json", stac_io=stac_io)
 
     headers = request_mock.call_args[1]["headers"]
-    assert headers == stac_io.headers
+    assert headers == {"User-Agent": "pystac", **stac_io.headers}
 
 
 @pytest.mark.vcr()