993 ruff got tough with the code

Author: teks

tests/extensions/test_custom.py

@@ -1,6 +1,5 @@
 """Tests creating a custom extension"""
 
-import unittest
 from datetime import datetime
 from typing import Any, Generic, TypeVar, cast
 
@@ -135,6 +134,7 @@ def test_add_to_item_asset(add_extension_hooks: None) -> None:
     item_as_dict = item.to_dict()
     assert item_as_dict["assets"]["foo"]["test:prop"] == "bar"
 
+
 def test_add_to_item(add_extension_hooks: None) -> None:
     item = Item("an-id", None, None, datetime.now(), {})
     custom = CustomExtension.ext(item, add_if_missing=True)
@@ -143,6 +143,7 @@ def test_add_to_item(add_extension_hooks: None) -> None:
     item_as_dict = item.to_dict()
     assert item_as_dict["properties"]["test:prop"] == "foo"
 
+
 def test_add_to_catalog(add_extension_hooks: None) -> None:
     catalog = Catalog("an-id", "a description")
     custom = CustomExtension.ext(catalog, add_if_missing=True)
@@ -151,6 +152,7 @@ def test_add_to_catalog(add_extension_hooks: None) -> None:
     catalog_as_dict = catalog.to_dict()
     assert catalog_as_dict["test:prop"] == "foo"
 
+
 def test_add_to_collection(add_extension_hooks: None) -> None:
     collection = Collection(
         "an-id",
@@ -166,6 +168,7 @@ def test_add_to_collection(add_extension_hooks: None) -> None:
     collection_as_dict = collection.to_dict()
     assert collection_as_dict["test:prop"] == "foo"
 
+
 def test_add_to_collection_asset(add_extension_hooks: None) -> None:
     collection = Collection(
         "an-id",
@@ -182,17 +185,17 @@ def test_add_to_collection_asset(add_extension_hooks: None) -> None:
     collection_as_dict = collection.to_dict()
     assert collection_as_dict["assets"]["foo"]["test:prop"] == "bar"
 
+
 def test_ext_non_stac_object(add_extension_hooks: None) -> None:
     with pytest.raises(ExtensionTypeError):
         CustomExtension.ext({})  # type: ignore
 
+
 def test_migrates(add_extension_hooks: None) -> None:
     item = Item("an-id", None, None, datetime.now(), {})
     item_as_dict = item.to_dict()
     item_as_dict["stac_version"] = "1.0.0-rc.1"
-    item_as_dict["stac_extensions"] = [
-        "https://example.com/v1.0/custom-schema.json"
-    ]
+    item_as_dict["stac_extensions"] = ["https://example.com/v1.0/custom-schema.json"]
     item_as_dict["properties"]["test:old-prop-name"] = "foo"
     item = Item.from_dict(item_as_dict, migrate=True)
     custom = CustomExtension.ext(item)

tests/extensions/test_eo.py

@@ -1,5 +1,4 @@
 import json
-import unittest
 
 import pytest
 
@@ -32,6 +31,7 @@ def test_band_create() -> None:
     assert band.solar_illumination == 42.0
     assert band.__repr__() == "<Band name=B01>"
 
+
 def test_band_description_unknown_band() -> None:
     desc = Band.band_description("rainbow")
     assert desc is None
@@ -51,6 +51,7 @@ def test_to_from_dict() -> None:
         item_dict = json.load(f)
     assert_to_from_dict(Item, item_dict)
 
+
 def test_add_to() -> None:
     item = Item.from_file(PLAIN_ITEM)
     assert EOExtension.get_schema_uri() not in item.stac_extensions
@@ -69,13 +70,15 @@ def test_add_to() -> None:
     ]
     assert len(eo_uris) == 1
 
+
 @pytest.mark.vcr()
 def test_validate_eo() -> None:
     item = pystac.Item.from_file(LANDSAT_EXAMPLE_URI)
     item2 = pystac.Item.from_file(BANDS_IN_ITEM_URI)
     item.validate()
     item2.validate()
 
+
 @pytest.mark.vcr()
 def test_bands() -> None:
     item = pystac.Item.from_file(BANDS_IN_ITEM_URI)
@@ -95,17 +98,19 @@ def test_bands() -> None:
 
     EOExtension.ext(item).bands = new_bands
     assert (
-        "Common name: red, Range: 0.6 to 0.7" ==
-        item.properties["eo:bands"][0]["description"]
+        "Common name: red, Range: 0.6 to 0.7"
+        == item.properties["eo:bands"][0]["description"]
     )
     assert len(EOExtension.ext(item).bands or []) == 3
     item.validate()
 
+
 def test_asset_bands_s2() -> None:
     item = pystac.Item.from_file(S2_ITEM_URI)
     mtd_asset = item.get_assets()["mtd"]
     assert EOExtension.ext(mtd_asset).bands is None
 
+
 @pytest.mark.vcr()
 def test_asset_bands() -> None:
     item = pystac.Item.from_file(LANDSAT_EXAMPLE_URI)
@@ -162,6 +167,7 @@ def test_asset_bands() -> None:
 
     assert len(item.assets["test"].extra_fields["eo:bands"]) == 3
 
+
 @pytest.mark.vcr()
 def test_cloud_cover() -> None:
     item = pystac.Item.from_file(LANDSAT_EXAMPLE_URI)
@@ -188,6 +194,7 @@ def test_cloud_cover() -> None:
 
     item.validate()
 
+
 def test_summaries() -> None:
     col = pystac.Collection.from_file(EO_COLLECTION_URI)
     eo_summaries = EOExtension.summaries(col)
@@ -219,6 +226,7 @@ def test_summaries() -> None:
     assert col_dict["summaries"]["eo:cloud_cover"]["minimum"] == 1.0
     assert col_dict["summaries"]["eo:snow_cover"]["minimum"] == 4.0
 
+
 def test_summaries_adds_uri() -> None:
     col = pystac.Collection.from_file(EO_COLLECTION_URI)
     col.stac_extensions = []
@@ -234,6 +242,7 @@ def test_summaries_adds_uri() -> None:
     EOExtension.remove_from(col)
     assert EOExtension.get_schema_uri() not in col.stac_extensions
 
+
 def test_read_pre_09_fields_into_common_metadata() -> None:
     eo_item = pystac.Item.from_file(
         TestCases.get_path(
@@ -244,6 +253,7 @@ def test_read_pre_09_fields_into_common_metadata() -> None:
     assert eo_item.common_metadata.platform == "landsat-8"
     assert eo_item.common_metadata.instruments == ["oli_tirs"]
 
+
 def test_reads_asset_bands_in_pre_1_0_version() -> None:
     item = pystac.Item.from_file(
         TestCases.get_path(
@@ -256,6 +266,7 @@ def test_reads_asset_bands_in_pre_1_0_version() -> None:
     assert len(bands or []) == 1
     assert get_opt(bands)[0].common_name == "cirrus"
 
+
 def test_reads_gsd_in_pre_1_0_version() -> None:
     eo_item = pystac.Item.from_file(
         TestCases.get_path(
@@ -265,6 +276,7 @@ def test_reads_gsd_in_pre_1_0_version() -> None:
 
     assert eo_item.common_metadata.gsd == 30.0
 
+
 def test_item_apply() -> None:
     item = pystac.Item.from_file(LANDSAT_EXAMPLE_URI)
     eo_ext = EOExtension.ext(item)
@@ -279,12 +291,14 @@ def test_item_apply() -> None:
     assert test_band.to_dict() == eo_ext.bands[0].to_dict()
     assert eo_ext.cloud_cover == 15
 
+
 def test_extend_invalid_object() -> None:
     link = pystac.Link("child", "https://some-domain.com/some/path/to.json")
 
     with pytest.raises(pystac.ExtensionTypeError):
         EOExtension.ext(link)  # type: ignore
 
+
 def test_extension_not_implemented() -> None:
     # Should raise exception if Item does not include extension URI
     item = pystac.Item.from_file(PLAIN_ITEM)
@@ -302,6 +316,7 @@ def test_extension_not_implemented() -> None:
     ownerless_asset = pystac.Asset.from_dict(asset.to_dict())
     _ = EOExtension.ext(ownerless_asset)
 
+
 def test_item_ext_add_to() -> None:
     item = pystac.Item.from_file(PLAIN_ITEM)
     assert EOExtension.get_schema_uri() not in item.stac_extensions
@@ -310,6 +325,7 @@ def test_item_ext_add_to() -> None:
 
     assert EOExtension.get_schema_uri() in item.stac_extensions
 
+
 def test_asset_ext_add_to() -> None:
     item = pystac.Item.from_file(PLAIN_ITEM)
     assert EOExtension.get_schema_uri() not in item.stac_extensions
@@ -319,6 +335,7 @@ def test_asset_ext_add_to() -> None:
 
     assert EOExtension.get_schema_uri() in item.stac_extensions
 
+
 def test_asset_ext_add_to_ownerless_asset() -> None:
     item = pystac.Item.from_file(PLAIN_ITEM)
     asset_dict = item.assets["thumbnail"].to_dict()
@@ -327,11 +344,13 @@ def test_asset_ext_add_to_ownerless_asset() -> None:
     with pytest.raises(pystac.STACError):
         _ = EOExtension.ext(asset, add_if_missing=True)
 
+
 def test_should_raise_exception_when_passing_invalid_extension_object() -> None:
-    with pytest.raises(ExtensionTypeError,
-            match=r"^EOExtension does not apply to type 'object'$"):
+    with pytest.raises(
+        ExtensionTypeError, match=r"^EOExtension does not apply to type 'object'$"
+    ):
         # calling it wrong purposely -------v
-        EOExtension.ext(object()) # type: ignore
+        EOExtension.ext(object())  # type: ignore
 
 
 def test_migration() -> None: