993 nonfunctional declassing in test_table.py

Author: teks

tests/extensions/test_table.py

@@ -1,4 +1,3 @@
-import unittest
 from pathlib import Path
 
 import pytest
@@ -8,61 +7,61 @@
 from pystac.extensions.table import Column, TableExtension
 from tests.utils import TestCases
 
+@pytest.fixture
+def example_uri() -> str:
+    return TestCases.get_path("data-files/table/item.json")
 
-class TableTest(unittest.TestCase):
-    def setUp(self) -> None:
-        self.example_uri = TestCases.get_path("data-files/table/item.json")
 
-    @pytest.mark.vcr()
-    def test_validate(self) -> None:
-        item = pystac.Item.from_file(self.example_uri)
-        item.validate()
+@pytest.mark.vcr()
+def test_validate(self) -> None:
+    item = pystac.Item.from_file(self.example_uri)
+    item.validate()
 
-    def test_extension_not_implemented(self) -> None:
-        # Should raise exception if item does not include extension URI
-        item = pystac.Item.from_file(self.example_uri)
-        item.stac_extensions.remove(TableExtension.get_schema_uri())
+def test_extension_not_implemented(self) -> None:
+    # Should raise exception if item does not include extension URI
+    item = pystac.Item.from_file(self.example_uri)
+    item.stac_extensions.remove(TableExtension.get_schema_uri())
 
-        with self.assertRaises(pystac.ExtensionNotImplemented):
-            _ = TableExtension.ext(item)
+    with self.assertRaises(pystac.ExtensionNotImplemented):
+        _ = TableExtension.ext(item)
 
-        # Should raise exception if owning item does not include extension URI
-        asset = item.assets["data"]
+    # Should raise exception if owning item does not include extension URI
+    asset = item.assets["data"]
 
-        with self.assertRaises(pystac.ExtensionNotImplemented):
-            _ = TableExtension.ext(asset)
+    with self.assertRaises(pystac.ExtensionNotImplemented):
+        _ = TableExtension.ext(asset)
 
-        # Should succeed if Asset has no owner
-        ownerless_asset = pystac.Asset.from_dict(asset.to_dict())
-        _ = TableExtension.ext(ownerless_asset)
+    # Should succeed if Asset has no owner
+    ownerless_asset = pystac.Asset.from_dict(asset.to_dict())
+    _ = TableExtension.ext(ownerless_asset)
 
-    def test_item_ext_add_to(self) -> None:
-        item = pystac.Item.from_file(self.example_uri)
-        item.stac_extensions.remove(TableExtension.get_schema_uri())
+def test_item_ext_add_to(self) -> None:
+    item = pystac.Item.from_file(self.example_uri)
+    item.stac_extensions.remove(TableExtension.get_schema_uri())
 
-        _ = TableExtension.ext(item, add_if_missing=True)
+    _ = TableExtension.ext(item, add_if_missing=True)
 
-        self.assertIn(TableExtension.get_schema_uri(), item.stac_extensions)
+    self.assertIn(TableExtension.get_schema_uri(), item.stac_extensions)
 
-    def test_asset_ext_add_to(self) -> None:
-        item = pystac.Item.from_file(self.example_uri)
-        item.stac_extensions.remove(TableExtension.get_schema_uri())
+def test_asset_ext_add_to(self) -> None:
+    item = pystac.Item.from_file(self.example_uri)
+    item.stac_extensions.remove(TableExtension.get_schema_uri())
 
-        self.assertNotIn(TableExtension.get_schema_uri(), item.stac_extensions)
-        asset = item.assets["data"]
+    self.assertNotIn(TableExtension.get_schema_uri(), item.stac_extensions)
+    asset = item.assets["data"]
 
-        _ = TableExtension.ext(asset, add_if_missing=True)
-        self.assertIn(TableExtension.get_schema_uri(), item.stac_extensions)
+    _ = TableExtension.ext(asset, add_if_missing=True)
+    self.assertIn(TableExtension.get_schema_uri(), item.stac_extensions)
 
-    def test_should_raise_exception_when_passing_invalid_extension_object(
-        self,
-    ) -> None:
-        self.assertRaisesRegex(
-            ExtensionTypeError,
-            r"^TableExtension does not apply to type 'object'$",
-            TableExtension.ext,
-            object(),
-        )
+def test_should_raise_exception_when_passing_invalid_extension_object(
+    self,
+) -> None:
+    self.assertRaisesRegex(
+        ExtensionTypeError,
+        r"^TableExtension does not apply to type 'object'$",
+        TableExtension.ext,
+        object(),
+    )
 
 
 def test_item_with_table_extension_is_serilalizable_and_roundtrips(