Remove schema uri from stac_extensions on migrate

Author: jsignell

pystac/extensions/item_assets.py

@@ -98,5 +98,11 @@ def migrate(
 
         super().migrate(obj, version, info)
 
+        # As of STAC spec version 1.1.0 item-assets are part of core
+        if obj["stac_version"] >= "1.1.0" and self.schema_uri in obj.get(
+            "stac_extensions", []
+        ):
+            obj["stac_extensions"].remove(self.schema_uri)
+
 
 ITEM_ASSETS_EXTENSION_HOOKS: ExtensionHooks = ItemAssetsExtensionHooks()

tests/serialization/test_migrate.py

@@ -75,8 +75,11 @@ def test_migrates_renamed_extension(self) -> None:
             )
         )
 
-        assert ItemAssetsExtension.has_extension(collection)
+        assert ItemAssetsExtension.get_schema_uri() not in collection.stac_extensions
+        assert not ItemAssetsExtension.has_extension(collection)
         assert "item_assets" in collection.extra_fields
+        assert collection.item_assets
+        assert collection.item_assets["thumbnail"].title == "Thumbnail"
 
     def test_migrates_pre_1_0_0_rc1_stats_summary(self) -> None:
         collection = pystac.Collection.from_file(

tests/test_item_assets.py

@@ -127,6 +127,9 @@ def test_extra_fields(collection: Collection) -> None:
 
 def test_item_assets_extension_is_deprecated() -> None:
     collection = Collection.from_file(CLASSIFICATION_COLLECTION_RASTER_URI)
+
+    assert ItemAssetsExtension.get_schema_uri() not in collection.stac_extensions
+
     with pytest.warns(DeprecatedWarning, match="top-level collection properties"):
         item_asset = ItemAssetsExtension.ext(
             collection, add_if_missing=True