enabled migration for Item, Collection, assets, item-assets

Author: jonas-hurst

pystac/extensions/mlm.py

@@ -2050,40 +2050,56 @@ class MLMExtensionHooks(ExtensionHooks):
 
     @staticmethod
     def _migrate_1_0_to_1_1(obj: dict[str, Any]) -> None:
-        if "mlm:framework" in obj["properties"]:
-            framework = obj["properties"]["mlm:framework"]
-            # remove invalid characters at beginning and end
-            forbidden_chars = [".", "_", "-", " ", "\t", "\n", "\r", "\f", "\v"]
-            if framework[0] in forbidden_chars or framework[-1] in forbidden_chars:
-                warnings.warn(
-                    "Value for mlm:framework is invalid in mlm>=1.1, as it must"
-                    "not start or end with one of the following characters: "
-                    "._- and whitespace. These characters are therefore removed while"
-                    "migrating the STAC object to v1.1.",
-                    SyntaxWarning,
-                )
-                while obj["properties"]["mlm:framework"][0] in forbidden_chars:
-                    new_str = obj["properties"]["mlm:framework"][1:]
-                    obj["properties"]["mlm:framework"] = new_str
-                while obj["properties"]["mlm:framework"][-1] in forbidden_chars:
-                    new_str = obj["properties"]["mlm:framework"][:-1]
-                    obj["properties"]["mlm:framework"] = new_str
-
-            # rename frameworks
-            if obj["properties"]["mlm:framework"] == "Scikit-learn":
-                obj["properties"]["mlm:framework"] = "scikit-learn"
-                warnings.warn(
-                    "mlm:framework value Scikit-learn is no longer valid in mlm>=1.1. "
-                    "Renaming it to scikit-learn",
-                    SyntaxWarning,
-                )
-            if obj["properties"]["mlm:framework"] == "Huggingface":
-                obj["properties"]["mlm:framework"] = "Hugging Face"
-                warnings.warn(
-                    "mlm:framework value Huggingface is no longer valid in mlm>=1.1. "
-                    "Renaming it to Hugging Face",
-                    SyntaxWarning,
-                )
+        def migrate(props_obj: dict[str, Any]) -> None:
+            if "mlm:framework" in props_obj:
+                framework = props_obj["mlm:framework"]
+                # remove invalid characters at beginning and end
+                forbidden_chars = [".", "_", "-", " ", "\t", "\n", "\r", "\f", "\v"]
+                if framework[0] in forbidden_chars or framework[-1] in forbidden_chars:
+                    warnings.warn(
+                        "Value for mlm:framework is invalid in mlm>=1.1, as it must"
+                        "not start or end with one of the following characters: "
+                        "._- and whitespace. These characters are therefore removed "
+                        "while migrating the STAC object to v1.1.",
+                        SyntaxWarning,
+                    )
+                    while props_obj["mlm:framework"][0] in forbidden_chars:
+                        new_str = props_obj["mlm:framework"][1:]
+                        props_obj["mlm:framework"] = new_str
+                    while props_obj["mlm:framework"][-1] in forbidden_chars:
+                        new_str = props_obj["mlm:framework"][:-1]
+                        props_obj["mlm:framework"] = new_str
+
+                # rename frameworks
+                if props_obj["mlm:framework"] == "Scikit-learn":
+                    props_obj["mlm:framework"] = "scikit-learn"
+                    warnings.warn(
+                        "mlm:framework value Scikit-learn is no longer valid in "
+                        "mlm>=1.1. Renaming it to scikit-learn",
+                        SyntaxWarning,
+                    )
+                if props_obj["mlm:framework"] == "Huggingface":
+                    props_obj["mlm:framework"] = "Hugging Face"
+                    warnings.warn(
+                        "mlm:framework value Huggingface is no longer valid in "
+                        "mlm>=1.1. Renaming it to Hugging Face",
+                        SyntaxWarning,
+                    )
+
+        if obj["type"] == "Feature":
+            migrate(obj["properties"])
+        if obj["type"] == "Collection":
+            migrate(obj)
+
+        if "assets" in obj:
+            for asset_name in obj["assets"]:
+                asset = obj["assets"][asset_name]
+                migrate(asset)
+
+        if obj["type"] == "Collection" and "item_assets" in obj:
+            for asset_name in obj["item_assets"]:
+                asset = obj["item_assets"][asset_name]
+                migrate(asset)
 
     @staticmethod
     def _migrate_1_1_to_1_2(obj: dict[str, Any]) -> None: