Issue 1470 paths windows #1475
Merged
Issue 1470 paths windows #1475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI passing example https://github.com/KeynesYouDigIt/pystac/actions/runs/11990954337 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1475 +/- ##
=======================================
Coverage 91.17% 91.17%
=======================================
Files 52 52
Lines 7251 7251
Branches 875 875
=======================================
Hits 6611 6611
Misses 460 460
Partials 180 180 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gadomski
requested changes
Nov 25, 2024
Thanks! This is great. No need to touch up commits, we squash-and-merge here. |
|
@gadomski Let me know if this is what you had in mind, thanks! |
gadomski
approved these changes
Dec 9, 2024
|
Awesome, thank you! Looks great. |
kmodali
pushed a commit
to kmodali/pystac
that referenced
this pull request
Oct 16, 2025
* test ko * isolate assertion (very simple check here..) * test windows correctly * cleanup comment * ruff fix * update changelog * update changelog * fix for 3.12 * really cover in new test * drive supported only on 3.13 * check one * check two * correct is_windows in tests * correct is_windows in tests part 2 * use os path for path count * use os path for path count in display as well * use os path for path count in display as well * rm whitespace * rm unecc comment * Update tests/test_catalog.py * factor out function * typo * factor out --------- Co-authored-by: Pete Gadomski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
Python 3.13 nuances the use of
os.path.isabs- https://docs.python.org/3/library/os.path.html#os.path.isabsSo I changed the test to reflect that
TODO
PR Checklist:
scripts/test)