-
Notifications
You must be signed in to change notification settings - Fork 126
feat: permissive extent deserialization #1559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! Just one suggestion.
Also this is a larger topic, but I was mildly persuaded at the STAC birds of a feather at CNG that if we are less permissive then it might make users complain to providers and encourage the production of higher quality STAC catalogs.
Co-authored-by: Julia Signell <[email protected]>
I get it, but so often the people creating broken STAC are wayyy separated from the feedback system. To me, warning feels like a nice compromise -- if pystac breaks on bad STAC, I think folks are just as likely to just not use pystac-client, make HTTP calls directly to dictionaries, and muddle on. |
Yeah that makes a ton of sense to me as well. I agree that is the more likely the path that people will see and once we lose them they are probably hard to get back. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1559 +/- ##
==========================================
+ Coverage 92.42% 92.43% +0.01%
==========================================
Files 55 55
Lines 8368 8371 +3
Branches 963 964 +1
==========================================
+ Hits 7734 7738 +4
Misses 449 449
+ Partials 185 184 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* feat: permissive extent deserialization * chore: update changelog * Update tests/test_collection.py Co-authored-by: Julia Signell <[email protected]> * fix: tests --------- Co-authored-by: Julia Signell <[email protected]>
Related Issue(s):
Description:
Relax collection extent serialization, as there's a surprising number of Collections out there in the real world without extents. Includes a sidecar relaxing of the type on the extent constructors.
PR Checklist:
pre-commit run --all-files)pytest)