fix: simple translate (#757)

Author: gadomski

crates/cli/Cargo.toml

@@ -48,6 +48,7 @@ url.workspace = true
 [dev-dependencies]
 assert_cmd.workspace = true
 rstest.workspace = true
+tempfile.workspace = true
 
 [lib]
 crate-type = ["lib", "cdylib"]

crates/cli/src/lib.rs

@@ -805,6 +805,17 @@ mod tests {
             .success();
     }
 
+    #[rstest]
+    fn translate_to_file(mut command: Command) {
+        let temp_dir = tempfile::env::temp_dir();
+        command
+            .arg("translate")
+            .arg("examples/simple-item.json")
+            .arg(temp_dir.join("simple-item.json"))
+            .assert()
+            .success();
+    }
+
     #[test]
     fn input_format() {
         let rustac = Rustac::parse_from(["rustac", "translate"]);

crates/core/CHANGELOG.md

@@ -23,6 +23,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 - Ensure geoparquet->json provides valid datetime strings (UTC) ([#711](https://github.com/stac-utils/rustac/pull/711)])
 - Some `Href` method names ([#747](https://github.com/stac-utils/rustac/pull/747))
 - Use `Href` for `Asset.href` 🙈 ([#752](https://github.com/stac-utils/rustac/pull/752))
+- `href::make_absolute` is now public ([#757](https://github.com/stac-utils/rustac/pull/757))
 
 ### Fixed
 

crates/core/src/href.rs

@@ -1,3 +1,5 @@
+//! Utilities and structures for working with hrefs.
+
 use crate::{Error, Result};
 use serde::{Deserialize, Serialize};
 use std::{
@@ -238,7 +240,8 @@ impl AsRef<Href> for Href {
     }
 }
 
-fn make_absolute(href: &str, base: &str) -> String {
+/// Makes an href absolute relative to a
+pub fn make_absolute(href: &str, base: &str) -> String {
     if href.starts_with('/') {
         href.to_string()
     } else {

crates/core/src/lib.rs

@@ -116,7 +116,7 @@ pub mod geo;
 pub mod geoarrow;
 #[cfg(feature = "geoparquet")]
 pub mod geoparquet;
-mod href;
+pub mod href;
 pub mod item;
 mod item_asset;
 mod item_collection;

crates/io/src/store.rs

@@ -25,14 +25,15 @@ where
             let s = if s.starts_with("/") {
                 format!("file://{s}")
             } else {
-                let path_buf = std::fs::canonicalize(s)?;
-                format!("file://{}", path_buf.display())
+                let current_dir = std::env::current_dir()?;
+                let s =
+                    stac::href::make_absolute(&s, &format!("{}/", current_dir.to_string_lossy()));
+                format!("file://{}", s)
             };
             Url::parse(&s)?
         }
     };
     let parse = || -> Result<(Box<dyn ObjectStore>, Path)> {
-        tracing::debug!("parsing url={url}");
         // It's technically inefficient to parse it twice, but we're doing this to
         // then do IO so who cares.
         let (scheme, path) = ObjectStoreScheme::parse(&url).map_err(object_store::Error::from)?;
@@ -68,6 +69,7 @@ where
         Ok(pair)
     };
     let (store, path) = parse()?;
+    tracing::debug!("{url} parsed into path {path}");
     url.set_path("");
     Ok((StacStore::new(Arc::new(store), url), path))
 }