refactor!: simplify cli (#516)

Nukes a lot of stuff, tbh.

Author: gadomski

crates/api/src/client.rs

@@ -220,7 +220,12 @@ impl Client {
         if let Some(headers) = headers.into() {
             request = request.headers(headers);
         }
-        let response = request.send().await?.error_for_status()?;
+        let response = request.send().await?;
+        if !response.status().is_success() {
+            let status_code = response.status();
+            let text = response.text().await.ok().unwrap_or_default();
+            return Err(Error::Request { status_code, text });
+        }
         response.json().await.map_err(Error::from)
     }
 
@@ -356,12 +361,8 @@ fn stream_pages(
 
 fn not_found_to_none<T>(result: Result<T>) -> Result<Option<T>> {
     let mut result = result.map(Some);
-    if let Err(Error::Reqwest(ref err)) = result {
-        if err
-            .status()
-            .map(|s| s == StatusCode::NOT_FOUND)
-            .unwrap_or_default()
-        {
+    if let Err(Error::Request { status_code, .. }) = result {
+        if status_code == StatusCode::NOT_FOUND {
             result = Ok(None);
         }
     }

crates/api/src/error.rs

@@ -75,6 +75,17 @@ pub enum Error {
     #[cfg(feature = "client")]
     Reqwest(#[from] reqwest::Error),
 
+    /// A search error.
+    #[error("HTTP status error ({status_code}): {text}")]
+    #[cfg(feature = "client")]
+    Request {
+        /// The status code
+        status_code: reqwest::StatusCode,
+
+        /// The text of the server response.
+        text: String,
+    },
+
     /// A search has both bbox and intersects.
     #[error("search has bbox and intersects")]
     SearchHasBboxAndIntersects(Box<Search>),

crates/cli/Cargo.toml

@@ -14,7 +14,7 @@ rust-version.workspace = true
 [features]
 default = ["pgstac"]
 duckdb = ["dep:stac-duckdb", "dep:duckdb"]
-pgstac = ["stac-server/pgstac", "dep:pgstac"]
+pgstac = ["stac-server/pgstac"]
 python = ["dep:pyo3", "pgstac"]
 
 [dependencies]
@@ -26,7 +26,6 @@ duckdb = { workspace = true, optional = true, features = [
 object_store.workspace = true
 openssl.workspace = true # same as duckdb, these openssls are just for bundling
 openssl-src.workspace = true
-pgstac = { workspace = true, optional = true }
 pyo3 = { workspace = true, optional = true }
 reqwest.workspace = true
 serde.workspace = true