fix(cli): use BufWriter for the output file

Author: gadomski

cli/Cargo.toml

@@ -46,6 +46,7 @@ thiserror = "1"
 tokio = { version = "1.23", features = ["macros", "rt-multi-thread"] }
 tokio-stream = "0.1"
 tracing = "0.1"
+tracing-subscriber = "0.3"
 url = "2"
 
 [dev-dependencies]

cli/src/args.rs

@@ -1,7 +1,10 @@
 use crate::{Format, Result, Subcommand};
 use clap::Parser;
 use stac::{Version, STAC_VERSION};
-use std::{fs::File, io::Write};
+use std::{
+    fs::File,
+    io::{BufWriter, Write},
+};
 
 /// CLI arguments.
 #[derive(Parser, Debug)]
@@ -243,7 +246,7 @@ impl Args {
     pub(crate) fn writer(&self) -> Result<Box<dyn Write + Send>> {
         if let Some(outfile) = self.subcommand.outfile() {
             let file = File::create(outfile)?;
-            Ok(Box::new(file))
+            Ok(Box::new(BufWriter::new(file)))
         } else {
             Ok(Box::new(std::io::stdout()))
         }

cli/src/lib.rs

@@ -137,5 +137,6 @@ mod python {
     }
 }
 
+use tracing_subscriber as _;
 #[cfg(test)]
 use {assert_cmd as _, tokio_test as _};

cli/src/main.rs

@@ -1,8 +1,13 @@
 use clap::Parser;
 use stac_cli::Args;
+use tracing_subscriber;
 
 #[tokio::main]
 async fn main() {
+    if std::env::var("STACRS_TRACING").is_ok() {
+        tracing_subscriber::fmt::init();
+    }
+
     let args = Args::parse();
     std::process::exit(match stac_cli::run(args).await {
         Ok(()) => 0,

cli/src/subcommand/translate.rs

@@ -1,8 +1,11 @@
 use crate::{Format, Result, Subcommand, TranslateArgs};
 use stac::Value;
+use tracing::{info, instrument};
 
 impl Subcommand {
+    #[instrument]
     pub(crate) async fn translate(args: TranslateArgs, input_format: Format) -> Result<Value> {
+        info!("reading {}", args.infile.as_deref().unwrap_or("<stdin>"));
         input_format.read_href(args.infile.as_deref()).await
     }
 }