Fixed end_datetime selection when splitting indices in a datetime-based indexing strategy. (#595)

A fix to my previous
MR(#537)
related to indices based on datetime / start_datetime / end_datetime.
During a rebase, one line was changed. Additionally, I’m adding a
fallback and logging for index selection.

PR Checklist:

- [ ] Code is formatted and linted (run `pre-commit run --all-files`)
- [ ] Tests pass (run `make test`)
- [ ] Documentation has been updated to reflect changes, if applicable
- [ ] Changes are added to the changelog

Author: Gomez324

CHANGELOG.md

@@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 ### Fixed
 
 - Fixed bulk_sync_prep_create_item to properly detect duplicates across indexes. [#575](https://github.com/stac-utils/stac-fastapi-elasticsearch-opensearch/pull/575)
+- Fixed end_datetime selection when splitting indices in a datetime-based indexing strategy. [#591](https://github.com/stac-utils/stac-fastapi-elasticsearch-opensearch/pull/591)
 
 ### Removed
 

stac_fastapi/sfeos_helpers/stac_fastapi/sfeos_helpers/database/index.py

@@ -165,7 +165,8 @@ def check_criteria(
             datetime_alias if use_datetime else start_datetime_alias
         )
 
-        filtered_indexes.append(primary_datetime_alias)
+        if primary_datetime_alias is not None:
+            filtered_indexes.append(primary_datetime_alias)
 
     return filtered_indexes
 

stac_fastapi/sfeos_helpers/stac_fastapi/sfeos_helpers/search_engine/inserters.py

@@ -257,8 +257,10 @@ async def _get_target_index_internal(
                     extract_date(latest_item["_source"]["properties"]["datetime"])
                 ),
                 end_datetime=str(
-                    extract_date(latest_item["_source"]["properties"]["end_datetime"])
-                ),
+                    extract_first_date_from_index(aliases_dict["end_datetime"])
+                )
+                if aliases_dict.get("end_datetime")
+                else None,
             )
 
             await self.datetime_manager.handle_oversized_index(

stac_fastapi/sfeos_helpers/stac_fastapi/sfeos_helpers/search_engine/selection/selectors.py

@@ -1,5 +1,4 @@
 """Async index selectors with datetime-based filtering."""
-
 from typing import Any, Dict, List, Optional, Tuple
 
 from stac_fastapi.core.utilities import get_bool_env