test fixes

Author: pedro-cf

stac_fastapi/tests/conftest.py

@@ -238,10 +238,17 @@ async def app():
     ).app
 
 
-@pytest_asyncio.fixture(scope="function")
-async def app_rate_limit(monkeypatch):
-    monkeypatch.setenv("STAC_FASTAPI_RATE_LIMIT", "2/minute")
+@pytest_asyncio.fixture(scope="session")
+async def app_client(app):
+    await create_index_templates()
+    await create_collection_index()
 
+    async with AsyncClient(app=app, base_url="http://test-server") as c:
+        yield c
+
+
+@pytest_asyncio.fixture(scope="session")
+async def app_rate_limit():
     settings = AsyncSettings()
 
     aggregation_extension = AggregationExtension(
@@ -285,21 +292,14 @@ async def app_rate_limit(monkeypatch):
     ).app
 
     # Set up rate limit
+    os.environ["STAC_FASTAPI_RATE_LIMIT"] = "2/minute"
     setup_rate_limit(app)
+    del os.environ["STAC_FASTAPI_RATE_LIMIT"]
 
     return app
 
 
 @pytest_asyncio.fixture(scope="session")
-async def app_client(app):
-    await create_index_templates()
-    await create_collection_index()
-
-    async with AsyncClient(app=app, base_url="http://test-server") as c:
-        yield c
-
-
-@pytest_asyncio.fixture(scope="function")
 async def app_client_rate_limit(app_rate_limit):
     await create_index_templates()
     await create_collection_index()

stac_fastapi/tests/rate_limit/test_rate_limit.py

@@ -8,7 +8,7 @@
 
 
 @pytest.mark.asyncio
-async def test_rate_limit(app_client_rate_limit: AsyncClient):
+async def test_rate_limit(app_client_rate_limit: AsyncClient, ctx):
     expected_status_codes = [200, 200, 429, 429, 429]
 
     for i, expected_status_code in enumerate(expected_status_codes):
@@ -22,3 +22,17 @@ async def test_rate_limit(app_client_rate_limit: AsyncClient):
         assert (
             status_code == expected_status_code
         ), f"Expected status code {expected_status_code}, but got {status_code}"
+
+
+@pytest.mark.asyncio
+async def test_rate_limit_no_limit(app_client: AsyncClient, ctx):
+    expected_status_codes = [200, 200, 200, 200, 200]
+
+    for i, expected_status_code in enumerate(expected_status_codes):
+        response = await app_client.get("/collections")
+        status_code = response.status_code
+
+        logger.info(f"Request {i+1}: Status code {status_code}")
+        assert (
+            status_code == expected_status_code
+        ), f"Expected status code {expected_status_code}, but got {status_code}"