Refresh after id changes.

Author: rhysrevans3

stac_fastapi/core/stac_fastapi/core/utilities.py

@@ -348,7 +348,7 @@ def add_commands(
 
 
 def test_commands(
-    commands: ESCommandSet, operation: PatchOperation, path: ElasticPath
+    commands: ESCommandSet, operation: PatchOperation, path: ElasticPath, params: Dict
 ) -> None:
     """Test value at path.
 
@@ -357,8 +357,11 @@ def test_commands(
         operation (PatchOperation): operation to run
         path (ElasticPath): path for value to be tested
     """
+    value = f"params.{path.param_key}"
+    params[path.param_key] = operation.value
+
     commands.add(
-        f"if (ctx._source.{path.es_path} != {operation.json_value})"
+        f"if (ctx._source.{path.es_path} != {value})"
         f"{{Debug.explain('Test failed `{path.path}` | "
         f"{operation.json_value} != ' + ctx._source.{path.es_path});}}"
     )

stac_fastapi/elasticsearch/stac_fastapi/elasticsearch/database_logic.py

@@ -1057,7 +1057,7 @@ async def json_patch_item(
         if new_item_id:
             item["id"] = new_item_id
             item = await self.async_prep_create_item(item=item, base_url=base_url)
-            await self.create_item(item=item, refresh=False)
+            await self.create_item(item=item, refresh=True)
 
             await self.delete_item(
                 item_id=item_id,
@@ -1353,7 +1353,7 @@ async def json_patch_collection(
             await self.update_collection(
                 collection_id=collection_id,
                 collection=collection,
-                refresh=False,
+                refresh=refresh,
             )
 
         return collection

stac_fastapi/opensearch/stac_fastapi/opensearch/database_logic.py

@@ -1062,7 +1062,7 @@ async def json_patch_item(
         if new_item_id:
             item["id"] = new_item_id
             item = await self.prep_create_item(item=item, base_url=base_url)
-            await self.create_item(item=item, refresh=False)
+            await self.create_item(item=item, refresh=True)
 
         if new_collection_id or new_item_id:
 
@@ -1332,7 +1332,7 @@ async def json_patch_collection(
             collection["id"] = new_collection_id
             collection["links"] = resolve_links([], base_url)
             await self.update_collection(
-                collection_id=collection_id, collection=collection, refresh=False
+                collection_id=collection_id, collection=collection, refresh=True
             )
 
         return collection