clean up, move env var

Author: jonhealy1

CHANGELOG.md

@@ -9,7 +9,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ### Added
 - Environment variable `ENABLE_COLLECTIONS_SEARCH_ROUTE` to turn on/off the `/collections-search` endpoint. [#478](https://github.com/stac-utils/stac-fastapi-elasticsearch-opensearch/pull/478)
-- POST and GET `/collections-search` endpoint for collections search queries, needed because POST /collections will not work when the Transactions Extension is enabled. [#478](https://github.com/stac-utils/stac-fastapi-elasticsearch-opensearch/pull/478)
+- POST and GET `/collections-search` endpoint for collections search queries, needed because POST /collections search will not work when the Transactions Extension is enabled. Defaults to `False` [#478](https://github.com/stac-utils/stac-fastapi-elasticsearch-opensearch/pull/478)
 - GET `/collections` collection search structured filter extension with support for both cql2-json and cql2-text formats. [#475](https://github.com/stac-utils/stac-fastapi-elasticsearch-opensearch/pull/475)
 - GET `/collections` collection search query extension. [#477](https://github.com/stac-utils/stac-fastapi-elasticsearch-opensearch/pull/477)
 - GET `/collections` collections search datetime filtering support. [#476](https://github.com/stac-utils/stac-fastapi-elasticsearch-opensearch/pull/476)

stac_fastapi/opensearch/stac_fastapi/opensearch/app.py

@@ -130,9 +130,6 @@
 # Collection search related variables
 collections_get_request_model = None
 
-# Collection search related variables
-collections_get_request_model = None
-
 if ENABLE_COLLECTIONS_SEARCH or ENABLE_COLLECTIONS_SEARCH_ROUTE:
     # Create collection search extensions
     collection_search_extensions = [

stac_fastapi/tests/conftest.py

@@ -316,11 +316,11 @@ def must_be_bob(
 async def route_dependencies_app():
     """Fixture to get the FastAPI app with custom route dependencies."""
 
+    os.environ["ENABLE_COLLECTIONS_SEARCH_ROUTE"] = "true"
+
     # Create a copy of the app config
     test_config = app_config.copy()
 
-    os.environ["ENABLE_COLLECTIONS_SEARCH_ROUTE"] = "true"
-
     # Define route dependencies
     test_config["route_dependencies"] = [
         ([{"method": "GET", "path": "/collections"}], [Depends(must_be_bob)])