Fix tests.

Author: rhysrevans3

stac_fastapi/tests/api/test_api.py

@@ -621,23 +621,19 @@ async def test_bbox_3d(app_client, ctx):
 @pytest.mark.asyncio
 async def test_patch_json_collection(app_client, ctx):
     data = {
-        "id": "new_id",
         "summaries": {"hello": "world", "gsd": [50], "instruments": None},
     }
 
     resp = await app_client.patch(f"/collections/{ctx.collection['id']}", json=data)
 
     assert resp.status_code == 200
 
-    new_resp = await app_client.get("/collections/new_id")
-    old_resp = await app_client.get(f"/collections/{ctx.collection['id']}")
+    new_resp = await app_client.get(f"/collections/{ctx.collection['id']}")
 
     assert new_resp.status_code == 200
-    assert old_resp.status_code == 404
 
     new_resp_json = new_resp.json()
 
-    assert new_resp_json["id"] == "new_id"
     assert new_resp_json["summaries"]["hello"] == "world"
     assert "instruments" not in new_resp_json["summaries"]
     assert new_resp_json["summaries"]["gsd"] == [50]
@@ -686,7 +682,6 @@ async def test_patch_operations_collection(app_client, ctx):
 async def test_patch_json_item(app_client, ctx):
 
     data = {
-        "id": "new_id",
         "properties": {"hello": "world", "proj:epsg": 1000, "landsat:column": None},
     }
 
@@ -696,17 +691,14 @@ async def test_patch_json_item(app_client, ctx):
 
     assert resp.status_code == 200
 
-    new_resp = await app_client.get(f"/collections/{ctx.item['collection']}/new_id")
-    old_resp = await app_client.get(
+    new_resp = await app_client.get(
         f"/collections/{ctx.item['collection']}/{ctx.item['id']}"
     )
 
     assert new_resp.status_code == 200
-    assert old_resp.status_code == 404
 
     new_resp_json = new_resp.json()
 
-    assert new_resp_json["id"] == "new_id"
     assert new_resp_json["properties"]["hello"] == "world"
     assert "landsat:column" not in new_resp_json["properties"]
     assert new_resp_json["properties"]["proj:epsg"] == 1000

stac_fastapi/tests/clients/test_es_os.py

@@ -316,9 +316,8 @@ async def test_json_patch_item_add(ctx, core_client, txn_client):
 
     assert updated_item["properties"]["foo"] == "bar"
     assert updated_item["properties"]["ext:hello"] == "world"
-    assert (
-        len(updated_item["properties"]["eo:bands"])
-        == len(ctx.item["properties"]["eo:bands"]) + 1
+    assert len(updated_item["properties"]["eo:bands"]) == len(
+        ctx.item["properties"]["eo:bands"] + 1
     )
     assert updated_item["properties"]["eo:bands"][1] == {
         "gsd": 10,
@@ -503,9 +502,8 @@ async def test_json_patch_item_copy(ctx, core_client, txn_client):
 
     assert updated_item["properties"]["foo"] == updated_item["properties"]["gsd"]
     assert updated_item["properties"]["bar"] == updated_item["properties"]["proj:epsg"]
-    assert (
-        len(updated_item["properties"]["eo:bands"])
-        == len(ctx.item["properties"]["eo:bands"]) + 1
+    assert len(updated_item["properties"]["eo:bands"]) == len(
+        ctx.item["properties"]["eo:bands"]
     )
     assert (
         updated_item["properties"]["eo:bands"][0]