fix: use NoDecode for cors origins

Otherwise, the env var syntax needs to be an encoded json string, which
is awkward.

Author: gadomski

stac_fastapi/pgstac/config.py

@@ -5,7 +5,7 @@
 from urllib.parse import quote_plus as quote
 
 from pydantic import BaseModel, BeforeValidator, Field, model_validator
-from pydantic_settings import BaseSettings, SettingsConfigDict
+from pydantic_settings import BaseSettings, NoDecode, SettingsConfigDict
 from stac_fastapi.types.config import ApiSettings
 from typing_extensions import Self
 
@@ -201,7 +201,9 @@ class Settings(ApiSettings):
     Implies that the `Transactions` extension is enabled.
     """
 
-    cors_origins: Annotated[Sequence[str], BeforeValidator(str_to_list)] = ("*",)
+    cors_origins: Annotated[Sequence[str], BeforeValidator(str_to_list), NoDecode] = (
+        "*",
+    )
     cors_origin_regex: Optional[str] = None
     cors_methods: Annotated[Sequence[str], BeforeValidator(str_to_list)] = (
         "GET",

tests/test_config.py

@@ -4,8 +4,9 @@
 
 import pytest
 from pydantic import ValidationError
+from pytest import MonkeyPatch
 
-from stac_fastapi.pgstac.config import PostgresSettings
+from stac_fastapi.pgstac.config import PostgresSettings, Settings
 
 
 async def test_pg_settings_with_env(monkeypatch):
@@ -74,3 +75,14 @@ async def test_pg_settings_attributes(monkeypatch):
                 postgres_dbname="pgstac",
                 _env_file=None,
             )
+
+
+def test_cors_origins(monkeypatch: MonkeyPatch) -> None:
+    monkeypatch.setenv(
+        "CORS_ORIGINS", "http://stac-fastapi-pgstac.test,http://stac-fastapi.test"
+    )
+    settings = Settings()
+    assert settings.cors_origins == [
+        "http://stac-fastapi-pgstac.test",
+        "http://stac-fastapi.test",
+    ]